BUG_ON() Conversion in drivers/s390/net/lcs.c
Subsystems (4)
PATCH 5/5 BUG_ON() Conversion in drivers/s390/net/lcs.c
hi,
this changes if() BUG(); constructs to BUG_ON() which is cleaner, contains unlikely() and can better optimized away.
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/s390/net/lcs.c renamed from drivers/s390/net/lcs.c.orig +5 -8
@@ -680,9 +680,8 @@ lcs_ready_buffer(struct lcs_channel *chaint index, rc;LCS_DBF_TEXT (5 , trace,"rdybuff" ); -if (buffer->state !=BUF_STATE_LOCKED && - buffer->state !=BUF_STATE_PROCESSED ) -BUG (); +BUG_ON (buffer->state !=BUF_STATE_LOCKED && + buffer->state !=BUF_STATE_PROCESSED );spin_lock_irqsave (get_ccwdev_lock (channel->ccwdev), flags); buffer->state =BUF_STATE_READY ; index = buffer - channel->iob;
@@ -706,8 +705,7 @@ __lcs_processed_buffer(struct lcs_channeint index, prev, next;LCS_DBF_TEXT (5 , trace,"prcsbuff" ); -if (buffer->state !=BUF_STATE_READY ) -BUG (); +BUG_ON (buffer->state !=BUF_STATE_READY ); buffer->state =BUF_STATE_PROCESSED ; index = buffer - channel->iob; prev = (index -1 ) & (LCS_NUM_BUFFS -1 );
@@ -739,9 +737,8 @@ lcs_release_buffer(struct lcs_channel *cunsigned long flags;LCS_DBF_TEXT (5 , trace,"relbuff" ); -if (buffer->state !=BUF_STATE_LOCKED && - buffer->state !=BUF_STATE_PROCESSED ) -BUG (); +BUG_ON (buffer->state !=BUF_STATE_LOCKED && + buffer->state !=BUF_STATE_PROCESSED );spin_lock_irqsave (get_ccwdev_lock (channel->ccwdev), flags); buffer->state =BUF_STATE_EMPTY ;spin_unlock_irqrestore (get_ccwdev_lock (channel->ccwdev), flags);
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors