Skip to contentSkip to conversation

iscsi update: pass correct skb to skb_trim

PATCH New Mike Christie 1 participant 1 message Feb 2, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/9 iscsi update: pass correct skb to skb_trim

Quoted 1 line

From [email protected]:

Wrong skb is passed to skb_trim in iscsi_if_get_stats.

drivers/scsi/scsi_transport_iscsi.c +3 -4
index b618685..79ca29e 100644
@@ -680,8 +680,7 @@ iscsi_if_send_reply(int pid, int seq, in
 }
 
 static int
-iscsi_if_get_stats(struct iscsi_transport *transport, struct sk_buff *skb,
-		   struct nlmsghdr *nlh)
+iscsi_if_get_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
 {
 	struct iscsi_uevent *ev = NLMSG_DATA(nlh);
 	struct iscsi_stats *stats;
@@ -732,7 +731,7 @@ iscsi_if_get_stats(struct iscsi_transpor
 					  stats->custom_length);
 		actual_size -= sizeof(*nlhstat);
 		actual_size = NLMSG_LENGTH(actual_size);
-		skb_trim(skb, NLMSG_ALIGN(actual_size));
+		skb_trim(skbstat, NLMSG_ALIGN(actual_size));
 		nlhstat->nlmsg_len = actual_size;
 
 		err = iscsi_unicast_skb(conn->z_pdu, skbstat);
@@ -923,7 +922,7 @@ iscsi_if_recv_msg(struct sk_buff *skb, s
 			err = -EINVAL;
 		break;
 	case ISCSI_UEVENT_GET_STATS:
-		err = iscsi_if_get_stats(transport, skb, nlh);
+		err = iscsi_if_get_stats(transport, nlh);
 		break;
 	default:
 		err = -EINVAL;