Skip to contentSkip to conversation

remove implicit sign bit in

PATCH New Darren Jenkins\ 1 participant 2 messages Feb 8, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove implicit sign bit in

Hello,

Here is a try at another patch

http://linuxicc.sourceforge.net/

Warnings/Error while compiling with Intel C Compiler

Says there is a Warning #108: implictly-signed bit field of length 1

in drivers/media/video/videocodec.h @ line 225 - 232.

These fields seem to be used to keep track of how the polarity of bits in registers work. So this patch converts them to unsigned.

--- linux-2.6.16-rc2/drivers/media/video/videocodec.h.orig 2006-02-08
15:29:21.000000000 +1100
+++ linux-2.6.16-rc2/drivers/media/video/videocodec.h 2006-02-08
15:30:42.000000000 +1100
@@ -222,14 +222,14 @@ M zr36055[1] 0001
/* ========================= */

struct vfe_polarity {
- int vsync_pol:1;
- int hsync_pol:1;
- int field_pol:1;
- int blank_pol:1;
- int subimg_pol:1;
- int poe_pol:1;
- int pvalid_pol:1;
- int vclk_pol:1;
+ unsigned vsync_pol:1;
+ unsigned hsync_pol:1;
+ unsigned field_pol:1;
+ unsigned blank_pol:1;
+ unsigned subimg_pol:1;
+ unsigned poe_pol:1;
+ unsigned pvalid_pol:1;
+ unsigned vclk_pol:1;
};

struct vfe_settings {

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw

PATCH 1/1 remove implicit sign bit in

Hello,

Here is re-send of the last patch without line wrapping (my bad, got it figured now)

http://linuxicc.sourceforge.net/

Warnings/Error while compiling with Intel C Compiler

Says there is a Warning #108: implictly-signed bit field of length 1

in drivers/media/video/videocodec.h @ line 225 - 232.

These fields seem to be used to keep track of how the polarity of bits in registers work. So this patch converts them to unsigned.

drivers/media/video/videocodec.h renamed from drivers/media/video/videocodec.h.orig +8 -8
@@ -222,14 +222,14 @@ M                       zr36055[1] 0001 
 /* ========================= */
 
 struct vfe_polarity {
-	int vsync_pol:1;
-	int hsync_pol:1;
-	int field_pol:1;
-	int blank_pol:1;
-	int subimg_pol:1;
-	int poe_pol:1;
-	int pvalid_pol:1;
-	int vclk_pol:1;
+	unsigned vsync_pol:1;
+	unsigned hsync_pol:1;
+	unsigned field_pol:1;
+	unsigned blank_pol:1;
+	unsigned subimg_pol:1;
+	unsigned poe_pol:1;
+	unsigned pvalid_pol:1;
+	unsigned vclk_pol:1;
 };
 
 struct vfe_settings {

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors