Skip to contentSkip to conversation

s390: add missing validation for dasd discipline specific ioctls

PATCH Horst Hummel 2 participants 2 messages Feb 8, 2006

lore
Share & tools
lore
#0 lore raw

Christoph Hellwig <[email protected]> wrote on 08.02.2006 15:08:39:

Quoted 4 lines · Heiko Carstens
Quoted 3 lines

From: Horst Hummel <[email protected]>

Because of missing discipline validition dasd ioctls calls may not

return

Quoted 5 lines
Quoted 3 lines

when called on a device handled by a different discipline. (e.g calling ECKD specific BIODASDGATTR on an FBA device). This addresses one of the issues Christoph has with the dasd driver.

Nack. the right way to do this is to have per-discipline ioctl

methods,

Quoted 3 lines

even if we can't remove the dasd_ioctl_register interface yet due to other disagreements. Just resurect those parts of my patch.

As I already tried to explain, the DASD ioctls are _not_ discipline related. A discipline is more or less a 'access method to a physical DASD'. Sine the ioctls are related to 'functional components', each ioctl could be valid in combination with none, one, two or every of the currently supported disciplines (ECKD, FBA, DIAG).

#1 lore raw
Quoted 13 lines · Horst Hummel

Christoph Hellwig <[email protected]> wrote on 08.02.2006 15:08:39:

Quoted 4 lines · Heiko Carstens
Quoted 3 lines

From: Horst Hummel <[email protected]>

Because of missing discipline validition dasd ioctls calls may not

return

Quoted 5 lines
Quoted 3 lines

when called on a device handled by a different discipline. (e.g calling ECKD specific BIODASDGATTR on an FBA device). This addresses one of the issues Christoph has with the dasd driver.

Nack. the right way to do this is to have per-discipline ioctl

methods,

Quoted 8 lines
Quoted 3 lines

even if we can't remove the dasd_ioctl_register interface yet due to other disagreements. Just resurect those parts of my patch.

As I already tried to explain, the DASD ioctls are _not_ discipline related. A discipline is more or less a 'access method to a physical DASD'. Sine the ioctls are related to 'functional components', each ioctl could be valid in combination with none, one, two or every of the currently supported disciplines (ECKD, FBA, DIAG).

Right now there's either ioctls that are valid for one (ECKD) or all
disciplines. As a special case you've put ioctls that are valid for
all disciplines into odd modules, but that's just another case of lots of crap in s390 drivers that needs sorting out.