Skip to contentSkip to conversation

How to send a patch

KJ Eric Sesterhenn 2 participants 3 messages Feb 23, 2006 – Feb 24, 2006 Kernel janitors

lore
Share & tools
lore
#0 lore raw

hi,

i have a few other patches to switch the rest of fs/ to kzalloc() usage, and I am wondering how to send it. Since there is always only one file touched in the subdirectories, so i guess sending them each individually would be too much overhead.

Thanks for comments, Eric

 adfs/super.c       |    3 +--
 aio.c              |    3 +--
 autofs/inode.c     |    3 +--
 autofs4/inode.c    |    4 +---
 bfs/inode.c        |    6 ++----
 binfmt_elf.c       |    3 +--
 binfmt_elf_fdpic.c |    3 +--
 bio.c              |    7 ++-----
 char_dev.c         |    7 ++-----
 compat.c           |    3 +--
 cramfs/inode.c     |    3 +--
 devfs/base.c       |    3 +--
 efs/super.c        |    3 +--
 exec.c             |    3 +--
 fat/inode.c        |    3 +--
 file.c             |    3 +--
 hpfs/super.c       |    3 +--
 isofs/inode.c      |    3 +--
 minix/inode.c      |    6 ++----
 ncpfs/inode.c      |    3 +--
 pipe.c             |    3 +--
 qnx4/inode.c       |    3 +--
 reiserfs/file.c    |    3 +--
 super.c            |    3 +--
 sysv/super.c       |    6 ++----
 ufs/super.c        |    3 +--
 26 files changed, 31 insertions(+), 65 deletions(-)

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#1 lore raw
Quoted 8 lines · Eric Sesterhenn

hi,

i have a few other patches to switch the rest of fs/ to kzalloc() usage, and I am wondering how to send it. Since there is always only one file touched in the subdirectories, so i guess sending them each individually would be too much overhead.

Patches don't need to be split pr file.

If you are doing the same change it's perfectly fine to do a lot of different files in one patch - as long as the patch makes one simple change across all files there's no problem there.

In case there are *many* files involved (or if they cover a lot of different areas) then it often makes sense to split pr top level directory, like one patch for arch/ one for drivers/ one mm/ etc. or if updating a lot of drivers you could do one for drivers/scsi/ , one for drivers/char/ etc etc.

Just use common sense :)

Quoting section 3 of Documentation/SubmittingPatches
(http://sosdg.org/~coywolf/lxr/source/Documentation/SubmittingPatches)
:

"
3) Separate your changes.

Separate _logical changes_ into a single patch file.

For example, if your changes include both bug fixes and performance enhancements for a single driver, separate those changes into two or more patches. If your changes include an API update, and a new driver which uses that new API, separate those into two patches.

On the other hand, if you make a single change to numerous files, group those changes into a single patch. Thus a single logical change is contained within a single patch.

If one patch depends on another patch in order for a change to be complete, that is OK. Simply note "this patch depends on patch X" in your patch description.

If you cannot condense your patch set into a smaller set of patches, then only post say 15 or so at a time and wait for review and integration.
"

Also read Documentation/HOWTO
(http://sosdg.org/~coywolf/lxr/source/Documentation/HOWTO) for more good info.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

#2 lore raw
In reply to Eric Sesterhenn
Quoted 16 lines · Jesper Juhl
Quoted 8 lines · Eric Sesterhenn

hi,

i have a few other patches to switch the rest of fs/ to kzalloc() usage, and I am wondering how to send it. Since there is always only one file touched in the subdirectories, so i guess sending them each individually would be too much overhead.

Patches don't need to be split pr file.

If you are doing the same change it's perfectly fine to do a lot of different files in one patch - as long as the patch makes one simple change across all files there's no problem there.

Quoted 7 lines

In case there are *many* files involved (or if they cover a lot of different areas) then it often makes sense to split pr top level directory, like one patch for arch/ one for drivers/ one mm/ etc. or if updating a lot of drivers you could do one for drivers/scsi/ , one for drivers/char/ etc etc.

Just use common sense :)

i tried and failed :-) The problem i have is that it would make sense to send one patch, since it is a subsystem on one hand, but on the other hand each filesystem has its own maintainer, which would be nice to have on the cc list for the stuff he maintains. Putting all of them to the cc list of the large patch gives them a lot of stuff they are not interested in.

Thanks for the comments, Eric

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors