Skip to contentSkip to conversation

powerpc: vdso 64bits gettimeofday bug

PATCH New Benjamin Herrenschmidt 1 participant 1 message Feb 25, 2006 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc: vdso 64bits gettimeofday bug

A bug in the assembly code of the vdso can cause gettimeofday() to hang or to return incorrect results. The wrong register was used to test for pending updates of the calibration variables and to create a dependency for subsequent loads. This fixes it.

---

Might be worth applying to the stable series too and/or distro kernels 2.6.15 and later

arch/powerpc/kernel/vdso64/gettimeofday.S +2 -2
@@ -225,9 +225,9 @@
   .cfi_startproc
 	/* check for update count & load values */
 1:	ld	r8,CFG_TB_UPDATE_COUNT(r3)
-	andi.	r0,r4,1			/* pending update ? loop */
+	andi.	r0,r8,1			/* pending update ? loop */
 	bne-	1b
-	xor	r0,r4,r4		/* create dependency */
+	xor	r0,r8,r8		/* create dependency */
 	add	r3,r3,r0
 
 	/* Get TB & offset it */