Skip to contentSkip to conversation

remove request_region from matroxfb_base.c

PATCH New Darren Jenkins\ 1 participant 1 message Mar 6, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove request_region from matroxfb_base.c

G'day list

matroxfb_base.c calles request_region() without checking it's return value @ 1737.
After getting advice from Petr Vandrovec it seems that this memory region isn't actually used in matroxfb_base.c, it was just reserved to stop vesafb and matrox being loaded on the same head. After looking at vesafb.c is seems that this doesn't work, as vesafb doesn't check the return value of request_region either.
So the patch below removes the request_region call because it doesn't actually do anything anymore.

Thanks again for your explanation Petr.

drivers/video/matrox/matroxfb_base.c renamed from drivers/video/matrox/matroxfb_base.c.orig +0 -2
@@ -1733,8 +1733,6 @@ static int initMatrox2(WPMINFO struct bo
 	}
 #endif	/* CONFIG_MTRR */
 
-	if (!ACCESS_FBINFO(devflags.novga))
-		request_region(0x3C0, 32, "matrox");
 	matroxfb_g450_connect(PMINFO2);
 	ACCESS_FBINFO(hw_switch->reset(PMINFO2));
 

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors