remove compatability /mm/slab.c
Subsystems (2)
PATCH 1/1 remove compatability /mm/slab.c
Quoted 18 lines · Christophe Jaillet
Hi all,
in /mm/slab.c we can find around line 263 :
struct
array_cache{
unsigned int avail;
unsigned int limit;
unsigned int batchcount;
unsigned int touched;
spinlock_tlock;
void *entry[0]; /*
* Must have this definition in here for the proper
* alignment ofarray_cache. Also simplifies accessing
* the entries.
* [0] is for gcc 2.95. It should really be []. */
};
Quoted 2 lines
The last line of the comment seems outdated, so maybe it could be removed and the [0] turned into [] as suggested which is IMO a bit clearer.
G'day list,
Here is a patch for the above.
It compiles fine, however I'm not sure if I should be doing anything else in support of this change or if this is all that is required.
mm/slab.c renamed from mm/slab.c.orig +5 -6
@@ -266,12 +266,11 @@ struct array_cache {unsigned int batchcount;unsigned int touched;spinlock_t lock; -void *entry[0 ];/* -* Must have this definition in here for the proper -* alignment of array_cache. Also simplifies accessing -* the entries. -* [0] is for gcc 2.95. It should really be []. -*/ +void *entry[];/* +* Must have this definition in here for the proper +* alignment of array_cache. Also simplifies accessing +* the entries. +*/ };/* bootstrap: The caches do not work without cpuarrays anymore,
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors