Skip to contentSkip to conversation

swsusp: drain high mem pages

PATCH In review Shaohua Li 2 participants 2 messages Mar 16, 2006

Subsystems (2)
lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

PATCH 1/1 swsusp: drain high mem pages

Highmem could be in pcp list as well.

---

 linux-2.6.15-root/kernel/power/snapshot.c |    1 +
 1 files changed, 1 insertion(+)
kernel/power/snapshot.c renamed from kernel/power/snapshot.c~drain_highmem +1 -0
diff -puN kernel/power/snapshot.c~drain_highmem kernel/power/snapshot.c
@@ -120,6 +120,7 @@ int save_highmem(void)
 	int res = 0;
 
 	pr_debug("swsusp: Saving Highmem\n");
+	drain_local_pages();
 	for_each_zone (zone) {
 		if (is_highmem(zone))
 			res = save_highmem_zone(zone);

_

#1 lore raw
Quoted 1 line · Shaohua Li

Highmem could be in pcp list as well.

This explains some strangeness I was seeing before.

OTOH it is nothing but ugly these days, so this is not urgent for 2.6.16.

ACK.
Pavel

Quoted 19 lines

---

 linux-2.6.15-root/kernel/power/snapshot.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN kernel/power/snapshot.c~drain_highmem kernel/power/snapshot.c

kernel/power/snapshot.c renamed from kernel/power/snapshot.c~drain_highmem +1 -0
@@ -120,6 +120,7 @@ int save_highmem(void)
 	int res = 0;
 
 	pr_debug("swsusp: Saving Highmem\n");
+	drain_local_pages();
 	for_each_zone (zone) {
 		if (is_highmem(zone))
 			res = save_highmem_zone(zone);

_

Signature · 1 line
220: * This program is distributed in the hope that it will be useful,