ads7846: pressure value limitation
PATCH 1/1 ads7846: pressure value limitation
Limit the pressure value to the maximum specified in the board-* specific file. Samples with pressure values beyond the maximum are considered non-reliable. For these report the x,y values measured last.
drivers/input/touchscreen/ads7846.c +17 -0
@@ -81,10 +83,14 @@ struct ads7846 {u16 model;u16 vref_delay_usecs;u16 x_plate_ohms; +u16 pressure_max;u8 read_x, read_y, read_z1, read_z2, pwrdown;u16 dummy;/* for the pwrdown read */ struct ts_event tc; +u16 last_x; +u16 last_y; +u16 last_pressure;struct spi_transfer xfer[10 ];struct spi_message msg[5 ];
@@ -345,6 +351,18 @@ static void ads7846_rx(void *ads) }else Rt =0 ; +if (Rt > ts->pressure_max) { +if (ts->last_pressure) { + x = ts->last_x; + y = ts->last_y; + } + Rt = ts->pressure_max; + } + + ts->last_x = x; + ts->last_y = y; + ts->last_pressure = Rt; +/* NOTE: "pendown" is inferred from pressure; we don't rely on * being able to check nPENIRQ status, or "friendly" trigger modes * (both-edges is much better than just-falling or low-level).
@@ -596,6 +615,7 @@ static int __devinit ads7846_probe(struc ts->model = pdata->model ? :7846 ; ts->vref_delay_usecs = pdata->vref_delay_usecs ? :100 ; ts->x_plate_ohms = pdata->x_plate_ohms ? :400 ; + ts->pressure_max = pdata->pressure_max ? :255 ; ts->debounce_max = pdata->debounce_max ? :1 ; ts->debounce_tol = pdata->debounce_tol ? :10 ;
Re: [PATCH] ads7846: pressure value limitationads
Resending the patch, by default there should be no limit on the pressure value.
Quoted 5 lines · Imre Deak
Limit the pressure value to the maximum specified in the board-* specific file. Samples with pressure values beyond the maximum are considered non-reliable. For these report the x,y values measured last.
Signed-off-by Imre Deak <[email protected]>
drivers/input/touchscreen/ads7846.c +17 -0
@@ -81,10 +81,14 @@ struct ads7846 {u16 model;u16 vref_delay_usecs;u16 x_plate_ohms; +u16 pressure_max;u8 read_x, read_y, read_z1, read_z2, pwrdown;u16 dummy;/* for the pwrdown read */ struct ts_event tc; +u16 last_x; +u16 last_y; +u16 last_pressure;struct spi_transfer xfer[10 ];struct spi_message msg[5 ];
@@ -345,6 +349,18 @@ static void ads7846_rx(void *ads) }else Rt =0 ; +if (Rt > ts->pressure_max) { +if (ts->last_pressure) { + x = ts->last_x; + y = ts->last_y; + } + Rt = ts->pressure_max; + } + + ts->last_x = x; + ts->last_y = y; + ts->last_pressure = Rt; +/* NOTE: "pendown" is inferred from pressure; we don't rely on * being able to check nPENIRQ status, or "friendly" trigger modes * (both-edges is much better than just-falling or low-level).
@@ -596,6 +612,7 @@ static int __devinit ads7846_probe(struc ts->model = pdata->model ? :7846 ; ts->vref_delay_usecs = pdata->vref_delay_usecs ? :100 ; ts->x_plate_ohms = pdata->x_plate_ohms ? :400 ; + ts->pressure_max = pdata->pressure_max ? : ~0 ; ts->debounce_max = pdata->debounce_max ? :1 ; ts->debounce_tol = pdata->debounce_tol ? :10 ;
Re: [PATCH] ads7846: pressure value limitationads
Quoted 4 lines · Imre Deak
Quoted 3 lines
Limit the pressure value to the maximum specified in the board-* specific file. Samples with pressure values beyond the maximum are considered non-reliable. For these report the x,y values measured last.
Note that this can be also done entirely in userspace.
Quoted 12 lines
Quoted 2 lines
Signed-off-by Imre Deak <[email protected]>_______________________________________________
Linux-omap-open-source mailing list
[email protected]
http://linux.omap.com/mailman/listinfo/linux-omap-open-source
Regards,
Andrew
--
balrog 2oo6
Dear Outlook users: Please remove me from your address books
http://www.newsforge.com/article.pl?sid=03/08/21/143258