Skip to contentSkip to conversation

PATCH: Fix interesting use of "extern" and also some bracketing

PATCH Applied Alan Cox 2 participants 2 messages Mar 27, 2006 – Mar 30, 2006 SCSI

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

Last of the set, just clean up some oddments. Assuming the whole set is now ok then the remaining differences are the setup of PIO_0 at reset and the ->data_xfer method.

drivers/scsi/libata-core.c +2 -2
index 1cb9813..18d5239 100644
@@ -2142,9 +2166,9 @@ static int sata_phy_resume(struct ata_po
  *	so makes reset sequence different from the original
  *	->phy_reset implementation and Jeff nervous.  :-P
  */
-extern void ata_std_probeinit(struct ata_port *ap)
+void ata_std_probeinit(struct ata_port *ap)
 {
-	if (ap->flags & ATA_FLAG_SATA && ap->ops->scr_read) {
+	if ((ap->flags & ATA_FLAG_SATA) && ap->ops->scr_read) {
 		sata_phy_resume(ap);
 		if (sata_dev_present(ap))
 			ata_busy_sleep(ap, ATA_TMOUT_BOOT_QUICK, ATA_TMOUT_BOOT);
Applied
#1 lore raw
Quoted 5 lines · Alan Cox

Last of the set, just clean up some oddments. Assuming the whole set is now ok then the remaining differences are the setup of PIO_0 at reset and the ->data_xfer method.

applied