Add target 'cscope' to Make [...]
PATCH 1/1 Add target 'cscope' to Make [...]
Hello list,
inside the automatic U-Boot patch tracking system a new ticket [DNX#2006040142001123] was created:
<snip>
Quoted 92 lines · Wolfgang Denk
Quoted 6 lines
Quoted 4 lines · In message <20060219150640.GA3310@aquarius> you wrote:
the following patch adds target 'cscope' to the main makefile. it also puts the list of directories with source files and the arguments to `find' into make variables.
Quoted 9 lines
On second look, I think this patch needs some more work:
Review
Quoted 4 lines
(quoted diff) +4
-0+# Directories with files for tag generation +TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\ + lib_$(ARCH) fs/cramfs fs/fat fs/fdos fs/jffs2 net disk rtc dtt drivers\ + drivers/sk98lin commonThis doesn't look complete to me - for example, how about post/ ?
post is included in $(SUBDIRS), but you're right, some 'fs' subdirs were missing. i should have examined it when i copied the directory list from the 'tags'/'etags' target.
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+# Arguments to `find' when generating a list of files for tag generation +TAGFINDARGS := \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)You should probably also exclude .git directories here, just in case.
oke. i also excluded .svn (subversion)
-h
---
Signed-off-by Horst Kronstorfer <[email protected]>CHANGELOG
* Added target 'cscope' to the main makefile. cscope (like ctags/etags) is
a tool for browsing source code. For further information go to the
cscope
website at http://cscope.sourceforge.net/. An alternative to cscope
named
freescope is available at http://freescope.sourceforge.net/.
Patch by Horst Kronstorfer, 20 Feb 2006Makefile +5
-0@@ -135,6 +135,14 @@ SUBDIRS = tools \ post/cpu .PHONY : $(SUBDIRS) +# Directories with files for tag generation +TAGDIRS := $(SUBDIRS) include lib_generic board/$(BOARDDIR) cpu/$(CPU)\ + lib_$(ARCH) fs net disk rtc dtt drivers common + +# Arguments to `find' when generating a list of files for taggeneration
Makefile +8
-10+TAGFINDARGS := \( -name CVS -prune \) -o \( -name .git -prune \) -o\ + \( -name .svn -prune \) -o \( -name '*.[ch]' -print \) + ######################################################################### #########################################################################@@ -179,19 +187,14 @@ gdbtools: depend dep: @for dir in $(SUBDIRS) ; do $(MAKE) -C $$dir .depend ; done +cscope: + find $(TAGDIRS) $(TAGFINDARGS) >cscope.files; cscope -b -q -k + tags: - ctags -w `find $(SUBDIRS) include \ - lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \ - fs/cramfs fs/fat fs/fdos fs/jffs2 \ - net disk rtc dtt drivers drivers/sk98lin common \ - \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)` + ctags -w `find $(TAGDIRS) $(TAGFINDARGS)` etags: - etags -a `find $(SUBDIRS) include \ - lib_generic board/$(BOARDDIR) cpu/$(CPU) lib_$(ARCH) \ - fs/cramfs fs/fat fs/fdos fs/jffs2 \ - net disk rtc dtt drivers drivers/sk98lin common \ - \( -name CVS -prune \) -o \( -name '*.[ch]' -print \)` + etags -a `find $(TAGDIRS) $(TAGFINDARGS)` System.map: u-boot @$(NM) $< | \
Makefile clobber: clean · line 1847
Quoted 8 lines
Makefile +1
-1@@ -1838,7 +1841,7 @@ clobber: clean -o -name '*.srec' -o -name '*.bin' -o -name u-boot.img \) \ -print0 \ | xargs -0 rm -f - rm -f $(OBJS) *.bak tags TAGS + rm -f $(OBJS) *.bak tags TAGS cscope.* rm -fr *.*~ rm -f u-boot u-boot.map u-boot.hex $(ALL) rm -f tools/crc32.c tools/environment.c tools/env/crc32.c
</snip>
Your U-Boot support team