Skip to contentSkip to conversation

Overrun in drivers/scsi/sim710.c

PATCH New Eric Sesterhenn 1 participant 1 message Apr 9, 2006 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Overrun in drivers/scsi/sim710.c

hi,

this fixes coverity bug id #480.
Since id_array is declared as id_array[MAX_SLOTS], the check for i>MAX_SLOTS is obviously false.

drivers/scsi/sim710.c renamed from drivers/scsi/sim710.c.orig +1 -1
@@ -75,7 +75,7 @@ param_setup(char *str)
 		else if(!strncmp(pos, "id:", 3)) {
 			if(slot == -1) {
 				printk(KERN_WARNING "sim710: Must specify slot for id parameter\n");
-			} else if(slot > MAX_SLOTS) {
+			} else if(slot >= MAX_SLOTS) {
 				printk(KERN_WARNING "sim710: Illegal slot %d for id %d\n", slot, val);
 			} else {
 				id_array[slot] = val;