Overrun in
Subsystems (2)
PATCH 1/1 Overrun in
hi,
since the arrays are declared as in_urbs[N_IN_URB] and out_urbs[N_OUT_URB] both for loops, go one over the end of the array. This fixes coverity id #555
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/usb/serial/option.c renamed from drivers/usb/serial/option.c.orig +2 -2
@@ -582,14 +582,14 @@ static void option_setup_urbs(struct usb portdata =usb_get_serial_port_data (port);/* Do indat endpoints first */ -for (j =0 ; j <=N_IN_URB ; ++j) { +for (j =0 ; j <N_IN_URB ; ++j) { portdata->in_urbs[j] =option_setup_urb (serial, port->bulk_in_endpointAddress,USB_DIR_IN , port, portdata->in_buffer[j],IN_BUFLEN , option_indat_callback); }/* outdat endpoints */ -for (j =0 ; j <=N_OUT_URB ; ++j) { +for (j =0 ; j <N_OUT_URB ; ++j) { portdata->out_urbs[j] =option_setup_urb (serial, port->bulk_out_endpointAddress,USB_DIR_OUT , port, portdata->out_buffer[j],OUT_BUFLEN , option_outdat_callback);
Hi,
Eric Sesterhenn:
Quoted 4 lines
since the arrays are declared as in_urbs[N_IN_URB] and out_urbs[N_OUT_URB] both for loops, go one over the end of the array. This fixes coverity id #555
Ouch. Thanks.
Signature · 1 line
Matthias Urlichs | {M:U} IT Design @ m-u-it.de | [email protected]