Skip to contentSkip to conversation

add new uevent

PATCH In review Kristen Accardi 2 participants 4 messages May 5, 2006 – May 8, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 add new uevent

Add dock uevents so that userspace can be notified of dock and undock events.

---
 include/linux/kobject.h |    2 ++
 lib/kobject_uevent.c    |    4 ++++
 2 files changed, 6 insertions(+)
include/linux/kobject.h +2 -0
@@ -46,6 +46,8 @@ enum kobject_action {
 	KOBJ_UMOUNT	= (__force kobject_action_t) 0x05,	/* umount event for block devices (broken) */
 	KOBJ_OFFLINE	= (__force kobject_action_t) 0x06,	/* device offline */
 	KOBJ_ONLINE	= (__force kobject_action_t) 0x07,	/* device online */
+	KOBJ_UNDOCK	= (__force kobject_action_t) 0x08, 	/* undocking */
+	KOBJ_DOCK	= (__force kobject_action_t) 0x09,	/* dock */
 };
 
 struct kobject {
lib/kobject_uevent.c +4 -0
@@ -48,6 +48,10 @@ static char *action_to_string(enum kobje
 		return "offline";
 	case KOBJ_ONLINE:
 		return "online";
+	case KOBJ_DOCK:
+		return "dock";
+	case KOBJ_UNDOCK:
+		return "undock";
 	default:
 		return NULL;
 	}
#1 lore raw
Quoted 17 lines · Kristen Accardi

Add dock uevents so that userspace can be notified of dock and undock events.

include/linux/kobject.h +2 -0
@@ -46,6 +46,8 @@ enum kobject_action {
 	KOBJ_UMOUNT	= (__force kobject_action_t) 0x05,	/* umount event for block devices (broken) */
 	KOBJ_OFFLINE	= (__force kobject_action_t) 0x06,	/* device offline */
 	KOBJ_ONLINE	= (__force kobject_action_t) 0x07,	/* device online */
+	KOBJ_UNDOCK	= (__force kobject_action_t) 0x08, 	/* undocking */
+	KOBJ_DOCK	= (__force kobject_action_t) 0x09,	/* dock */
 };
 
 struct kobject {

lib/kobject_uevent.c static char *action_to_string(enum kobje · line 57

Quoted 10 lines
lib/kobject_uevent.c +4 -0
@@ -48,6 +48,10 @@ static char *action_to_string(enum kobje
 		return "offline";
 	case KOBJ_ONLINE:
 		return "online";
+	case KOBJ_DOCK:
+		return "dock";
+	case KOBJ_UNDOCK:
+		return "undock";
 	default:
 		return NULL;
 	}

Where exactly are you going to generate them?

#2 lore raw
Quoted 14 lines · Alexey Dobriyan
Quoted 13 lines · Kristen Accardi

Add dock uevents so that userspace can be notified of dock and undock events.

include/linux/kobject.h +2 -0
@@ -46,6 +46,8 @@ enum kobject_action {
 	KOBJ_UMOUNT	= (__force kobject_action_t) 0x05,	/* umount event for block devices (broken) */
 	KOBJ_OFFLINE	= (__force kobject_action_t) 0x06,	/* device offline */
 	KOBJ_ONLINE	= (__force kobject_action_t) 0x07,	/* device online */
+	KOBJ_UNDOCK	= (__force kobject_action_t) 0x08, 	/* undocking */
+	KOBJ_DOCK	= (__force kobject_action_t) 0x09,	/* dock */
 };
 
Quoted 16 lines
Quoted 4 lines
include/linux/kobject.h +0 -0
 struct kobject {

lib/kobject_uevent.c static char *action_to_string(enum kobje · line 57

Quoted 10 lines
lib/kobject_uevent.c +4 -0
@@ -48,6 +48,10 @@ static char *action_to_string(enum kobje
 		return "offline";
 	case KOBJ_ONLINE:
 		return "online";
+	case KOBJ_DOCK:
+		return "dock";
+	case KOBJ_UNDOCK:
+		return "undock";
 	default:
 		return NULL;
 	}

Where exactly are you going to generate them?

Hi Alexey,
These events will be generated from the dock driver. The patch for this will be submitted in the next day or 2 (assuming everyone is ok with adding these events).

Kristen

#3 lore raw
Quoted 32 lines · Kristen Accardi
Quoted 14 lines · Alexey Dobriyan
Quoted 13 lines · Kristen Accardi

Add dock uevents so that userspace can be notified of dock and undock events.

include/linux/kobject.h +2 -0
@@ -46,6 +46,8 @@ enum kobject_action {
 	KOBJ_UMOUNT	= (__force kobject_action_t) 0x05,	/* umount event for block devices (broken) */
 	KOBJ_OFFLINE	= (__force kobject_action_t) 0x06,	/* device offline */
 	KOBJ_ONLINE	= (__force kobject_action_t) 0x07,	/* device online */
+	KOBJ_UNDOCK	= (__force kobject_action_t) 0x08, 	/* undocking */
+	KOBJ_DOCK	= (__force kobject_action_t) 0x09,	/* dock */
 };
 
Quoted 16 lines
Quoted 4 lines
include/linux/kobject.h +0 -0
 struct kobject {

lib/kobject_uevent.c static char *action_to_string(enum kobje · line 57

Quoted 10 lines
lib/kobject_uevent.c +4 -0
@@ -48,6 +48,10 @@ static char *action_to_string(enum kobje
 		return "offline";
 	case KOBJ_ONLINE:
 		return "online";
+	case KOBJ_DOCK:
+		return "dock";
+	case KOBJ_UNDOCK:
+		return "undock";
 	default:
 		return NULL;
 	}

Where exactly are you going to generate them?

Quoted 4 lines

Hi Alexey,
These events will be generated from the dock driver. The patch for this will be submitted in the next day or 2 (assuming everyone is ok with adding these events).

Without seeing actual driver it's impossible to say OK or not.

Post the driver when you're ready and make those two chunks a part of whole patch.