Skip to contentSkip to conversation

i386 implementation of cpu bulk removal

PATCH In review Shaohua Li 2 participants 3 messages May 8, 2006

lore
Share & tools
lore

Shaohua Li

author
#0 lore raw

PATCH 6/10 i386 implementation of cpu bulk removal

i386 specific implementation of cpu bulk removal. Add the config and make __cpu_die/__cpu_disable work with cpumask_t.

---

 linux-2.6.17-rc3-root/arch/i386/Kconfig          |   11 ++
 linux-2.6.17-rc3-root/arch/i386/kernel/smpboot.c |  118 ++++++++++++++++-------
 2 files changed, 97 insertions(+), 32 deletions(-)
arch/i386/Kconfig renamed from arch/i386/Kconfig~i386-bulk-cpu-hotplug +11 -0
diff -puN arch/i386/Kconfig~i386-bulk-cpu-hotplug arch/i386/Kconfig
@@ -763,6 +763,17 @@ config HOTPLUG_CPU
 
 	  Say N.
 
+config BULK_CPU_REMOVE
+	bool "Support for bulk removal of CPUs (EXPERIMENTAL)"
+	depends on HOTPLUG_CPU && EXPERIMENTAL
+	help
+	  Say Y if need the ability to remove more than one cpu during cpu
+	  removal. Current mechanisms may be in-efficient when a NUMA
+	  node is being removed, which would involve removing one cpu at a
+	  time. This will let interrupts, timers and processes to be bound
+	  to a CPU that might be removed right after the current cpu is
+	  being offlined.
+
 endmenu
 
 
arch/i386/kernel/smpboot.c renamed from arch/i386/kernel/smpboot.c~i386-bulk-cpu-hotplug +86 -32

161 lines not on this page · raw message

_

#1 lore raw

arch/i386/Kconfig config HOTPLUG_CPU · line 776

Quoted 11 lines · Shaohua Li
arch/i386/Kconfig renamed from arch/i386/Kconfig~i386-bulk-cpu-hotplug +11 -0
+config BULK_CPU_REMOVE
+	bool "Support for bulk removal of CPUs (EXPERIMENTAL)"
+	depends on HOTPLUG_CPU && EXPERIMENTAL
+	help
+	  Say Y if need the ability to remove more than one cpu during cpu
+	  removal. Current mechanisms may be in-efficient when a NUMA
+	  node is being removed, which would involve removing one cpu at a
+	  time. This will let interrupts, timers and processes to be bound
+	  to a CPU that might be removed right after the current cpu is
+	  being offlined.
+

Hello Shaohua,
Is this config option a temporary/staging thing?

Thanks,
Zwane

author
#2 lore raw
Quoted 16 lines · Zwane Mwaikambo

arch/i386/Kconfig config HOTPLUG_CPU · line 776

Quoted 11 lines · Shaohua Li
arch/i386/Kconfig renamed from arch/i386/Kconfig~i386-bulk-cpu-hotplug +11 -0
+config BULK_CPU_REMOVE
+	bool "Support for bulk removal of CPUs (EXPERIMENTAL)"
+	depends on HOTPLUG_CPU && EXPERIMENTAL
+	help
+	  Say Y if need the ability to remove more than one cpu during cpu
+	  removal. Current mechanisms may be in-efficient when a NUMA
+	  node is being removed, which would involve removing one cpu at a
+	  time. This will let interrupts, timers and processes to be bound
+	  to a CPU that might be removed right after the current cpu is
+	  being offlined.
+

Hello Shaohua,
Is this config option a temporary/staging thing?

I think it's temporary. Bulk cpu removal could be default of CPU hotplug.

Thanks,
Shaohua