Skip to contentSkip to conversation

2.6.6 SN2 specific prom flag in mca.c

PATCH In review Keith Owens 4 participants 4 messages May 10, 2004

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 2.6.6 SN2 specific prom flag in mca.c

SN2 prom needs an extra flag on the MCA setup call.

Index: 2.6.6/arch/ia64/kernel/mca.c
=================================--- 2.6.6.orig/arch/ia64/kernel/mca.c 2004-04-05 12:43:31.000000000 -0500
+++ 2.6.6/arch/ia64/kernel/mca.c 2004-04-05 12:52:48.000000000 -0500
@@ -1207,6 +1207,9 @@
s64 rc;
struct ia64_sal_retval isrv;
u64 timeout = IA64_MCA_RENDEZ_TIMEOUT; /* platform specific */
+ u64 mca_flags = SAL_MC_PARAM_RZ_ALWAYS; /* platform specific */
+ if (ia64_platform_is("sn2"))
+ mca_flags |= 0x8; /* SGI prom specific */

IA64_MCA_DEBUG("%s: begin\n", __FUNCTION__);

@@ -1224,7 +1227,7 @@
SAL_MC_PARAM_MECHANISM_INT, IA64_MCA_RENDEZ_VECTOR, timeout,
- SAL_MC_PARAM_RZ_ALWAYS);
+ mca_flags);
rc = isrv.status;
if (rc = 0)
break;

#1 lore raw
Quoted 1 line · Keith Owens

SN2 prom needs an extra flag on the MCA setup call.

If the flag is needed always and only on SN2, why doesn't the prom just set it implicitly?

Quoted 24 lines

Index: 2.6.6/arch/ia64/kernel/mca.c
=================================> --- 2.6.6.orig/arch/ia64/kernel/mca.c 2004-04-05 12:43:31.000000000 -0500
+++ 2.6.6/arch/ia64/kernel/mca.c 2004-04-05 12:52:48.000000000 -0500

(quoted diff) +4 -2
@@ -1207,6 +1207,9 @@
 	s64 rc;
 	struct ia64_sal_retval isrv;
 	u64 timeout = IA64_MCA_RENDEZ_TIMEOUT;	/* platform specific */
+	u64 mca_flags = SAL_MC_PARAM_RZ_ALWAYS;	/* platform specific */
+	if (ia64_platform_is("sn2"))
+		mca_flags |= 0x8;		/* SGI prom specific */
 
 	IA64_MCA_DEBUG("%s: begin\n", __FUNCTION__);
 
@@ -1224,7 +1227,7 @@
 					      SAL_MC_PARAM_MECHANISM_INT,
 					      IA64_MCA_RENDEZ_VECTOR,
 					      timeout,
-					      SAL_MC_PARAM_RZ_ALWAYS);
+					      mca_flags);
 		rc = isrv.status;
 		if (rc = 0)
 			break;
 
-
#2 lore raw
In reply to Keith Owens
Quoted 5 lines · Keith Owens
Quoted 1 line

SN2 prom needs an extra flag on the MCA setup call.

If the flag is needed always and only on SN2, why doesn't the prom just set it implicitly?

The SAL spec is unhelpful about platform extensions here, it defines bits 2-63 as "Reserved, must be zero".

-Tony

#3 lore raw
In reply to Keith Owens

Keith,

You have been around long enough to do better than that. There is no way I'm going to accept a patch as ugly as this.

Hints:

- Any patch that contains ia64_platform_is() raises suspicion. It's almost always wrong to use this macro.

- Magic constant of 0x8? What the heck is that about?

	--david

------------------------------------------------------------------
From: Keith Owens <[email protected]>
Sender: [email protected]
To: [email protected]
Subject: [patch] 2.6.6 SN2 specific prom flag in mca.c
Date: Mon, 10 May 2004 15:55:36 +1000

SN2 prom needs an extra flag on the MCA setup call.

Index: 2.6.6/arch/ia64/kernel/mca.c
=================================--- 2.6.6.orig/arch/ia64/kernel/mca.c 2004-04-05 12:43:31.000000000 -0500
+++ 2.6.6/arch/ia64/kernel/mca.c 2004-04-05 12:52:48.000000000 -0500
@@ -1207,6 +1207,9 @@
s64 rc;
struct ia64_sal_retval isrv;
u64 timeout = IA64_MCA_RENDEZ_TIMEOUT; /* platform specific */
+ u64 mca_flags = SAL_MC_PARAM_RZ_ALWAYS; /* platform specific */
+ if (ia64_platform_is("sn2"))
+ mca_flags |= 0x8; /* SGI prom specific */

IA64_MCA_DEBUG("%s: begin\n", __FUNCTION__);

@@ -1224,7 +1227,7 @@
SAL_MC_PARAM_MECHANISM_INT, IA64_MCA_RENDEZ_VECTOR, timeout,
- SAL_MC_PARAM_RZ_ALWAYS);
+ mca_flags);
rc = isrv.status;
if (rc = 0)
break;

-
To unsubscribe from this list: send the line "unsubscribe linux-ia64" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html