Skip to contentSkip to conversation

Cyclades Cleanup

PATCH In review Eric Sesterhenn 2 participants 2 messages Jun 11, 2006 – Jun 12, 2006 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Cyclades Cleanup

hi,

coverity choked at two !tty checks, in places where tty can never be NULL. Since it removes some code we should remove these checks. (Coverity ids #763,#762)

Signed-off-by Eric Sesterhenn <[email protected]>

drivers/char/cyclades.c renamed from drivers/char/cyclades.c.orig +2 -2
@@ -2833,7 +2833,7 @@ cy_write(struct tty_struct * tty, const 
         return 0;
     }
         
-    if (!tty || !info->xmit_buf || !tmp_buf){
+    if (!info->xmit_buf || !tmp_buf){
         return 0;
     }
 
@@ -2884,7 +2884,7 @@ cy_put_char(struct tty_struct *tty, unsi
     if (serial_paranoia_check(info, tty->name, "cy_put_char"))
         return;
 
-    if (!tty || !info->xmit_buf)
+    if (!info->xmit_buf)
         return;
 
     CY_LOCK(info, flags);
Acked-by on v1 1/1
#1 lore raw

Ar Sul, 2006-06-11 am 23:14 +0200, ysgrifennodd Eric Sesterhenn:

Quoted 7 lines

hi,

coverity choked at two !tty checks, in places where tty can never be NULL. Since it removes some code we should remove these checks. (Coverity ids #763,#762)

Signed-off-by Eric Sesterhenn <[email protected]>