ARM: OMAP: Use read/write_reg functions for PRCM.
PATCH 2/2 ARM: OMAP: Use read/write_reg functions for PRCM.
pm.c changes.
- Use prcm_read/write_reg for preg(...)?? _or_ get function for each of that reg.
- get/set_reg functions for INTC registers??
- get_reg functions for SDRC_DLLA/B for using with omap2_sram_suspend ??
- Adding proc based register information as in OMAP1?
pm-domain.c
- Add if (cpu_is_omap2420()) and assigning prcm_base at init.
- Use prcm_readl/writel for other registers which uses _reg32 based access as of now.
Signature · 1 line
http://www.fastmail.fm - Does exactly what it says on the tin
Hi,
Quoted 1 line · Komal Shah
This patch will break the
pm.candpm-domain.cifCONFIG_PMis enabled.
No problem. I'd actually prefer to have a patch that does not touch pm.c and pm-domain.c. There's another patch coming for PM stuff that already does not need prcm-regs.h much any longer.
Quoted 9 lines
pm.cchanges.
- Use prcm_read/write_reg for preg(...)?? _or_ get function for each of that reg.- get/set_reg functions for INTC registers??
-
get_regfunctions for SDRC_DLLA/B for using withomap2_sram_suspend??
Quoted 6 lines
- Adding proc based register information as in OMAP1?
pm-domain.c
- Add if (cpu_is_omap2420()) and assigningprcm_baseat init.
- Use prcm_readl/writel for other registers which uses_reg32based access as of now.
In general looks OK to me, could you please refresh and repost all your pending patches? Let's plan on starting to integrate this as soon as we have verified the generic irq stuff has not broken anything.
Regards,
Tony