SKB leak in drivers/isdn/i4l/isdn_x25iface.c
PATCH 1/1 SKB leak in drivers/isdn/i4l/isdn_x25iface.c
hi,
coverity spotted this leak (id #613), when
we are not configured, we return without
freeing the allocated skb.
Signed-off-by Eric Sesterhenn <[email protected]>
drivers/isdn/i4l/isdn_x25iface.c renamed from drivers/isdn/i4l/isdn_x25iface.c.orig +3 -1
@@ -208,7 +208,7 @@ static int isdn_x25iface_receive(struct*/ static int isdn_x25iface_connect_ind (struct concap_proto *cprot) { -struct sk_buff * skb =dev_alloc_skb (1 ); +struct sk_buff * skb;enum wan_states *state_p = &( ( (ix25_pdata_t *) (cprot->proto_data) ) -> state); IX25DEBUG( "isdn_x25iface_connect_ind %s \n"
@@ -220,6 +220,8 @@ static int isdn_x25iface_connect_ind(strreturn -1 ; } *state_p =WAN_CONNECTED ; + + skb =dev_alloc_skb (1 );if ( skb ){ *(skb_put (skb,1 ) ) =0x01 ; skb->protocol =x25_type_trans (skb, cprot->net_dev);
David Miller
AppliedFrom: Eric Sesterhenn <[email protected]>
Date: Wed, 28 Jun 2006 22:06:07 +0200
Quoted 7 lines
hi,
coverity spotted this leak (id #613), when
we are not configured, we return without
freeing the allocated skb.Signed-off-by Eric Sesterhenn <[email protected]>
Applied, thanks.