Skip to contentSkip to conversation

Remove asm/atomic.h from user visibility

PATCH New David Woodhouse 1 participant 2 messages Jul 10, 2006 2 messages not in the archive Generic include/asm header files

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 2/3 Remove asm/atomic.h from user visibility

[HDRINSTALL] Remove asm/atomic.h from user visibility

This isn't suitable for userspace to see -- the kernel headers are not a random library of stuff for userspace; they're only there to define the kernel<->user ABI for system libraries and tools. Anything which _was_ abusing asm/atomic.h from userspace was probably broken anyway -- as it often didn't even give atomic operation.

include/asm-generic/Kbuild.asm +1 -1
index da163c1..bdb8b08 100644
@@ -5,7 +5,7 @@ unifdef-y += a.out.h auxvec.h byteorder.
 	statfs.h termbits.h termios.h timex.h types.h unistd.h user.h
 
 # These really shouldn't be exported
-unifdef-y += atomic.h io.h
+unifdef-y += io.h
 
 # These probably shouldn't be exported
 unifdef-y += elf.h page.h
Signature · 1 line
dwmw2

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 3/3 Remove asm/io.h from user visibility

There's no excuse for userspace abusing this kernel header -- the kernel's headers are not intended to provide a library of helper routines for userspace. Using <asm/io.h> from userspace is broken on most architectures anyway. Just say 'no'.

include/asm-generic/Kbuild.asm +0 -3
index bdb8b08..6b16dda 100644
@@ -4,8 +4,5 @@ unifdef-y += a.out.h auxvec.h byteorder.
 	sigcontext.h siginfo.h signal.h socket.h sockios.h stat.h	\
 	statfs.h termbits.h termios.h timex.h types.h unistd.h user.h
 
-# These really shouldn't be exported
-unifdef-y += io.h
-
 # These probably shouldn't be exported
 unifdef-y += elf.h page.h
Signature · 1 line
dwmw2