Skip to contentSkip to conversation

iscsi bugfixes: fix mem leaks in libiscsi

PATCH In review Mike Christie 1 participant 1 message Jul 24, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 10/11 iscsi bugfixes: fix mem leaks in libiscsi

We were leaking some strings. This patch just frees them.

drivers/scsi/libiscsi.c +3 -0
index c628c63..5884cd2 100644
@@ -1357,6 +1357,8 @@ void iscsi_session_teardown(struct iscsi
 	iscsi_pool_free(&session->mgmtpool, (void**)session->mgmt_cmds);
 	iscsi_pool_free(&session->cmdpool, (void**)session->cmds);
 
+	kfree(session->targetname);
+
 	iscsi_destroy_session(cls_session);
 	scsi_host_put(shost);
 	module_put(owner);
@@ -1491,6 +1493,7 @@ void iscsi_conn_teardown(struct iscsi_cl
 
 	spin_lock_bh(&session->lock);
 	kfree(conn->data);
+	kfree(conn->persistent_address);
 	__kfifo_put(session->mgmtpool.queue, (void*)&conn->login_mtask,
 		    sizeof(void*));
 	list_del(&conn->item);