OMAP: Add keypad driver #2
PATCH 1/1 OMAP: Add keypad driver #2
This is a revised patch as per the review comments from the Andrew on thread:
http://lkml.org/lkml/2006/7/22/19
Please review it and give me the Ack if looks ok.
---Komal Shah
http://komalshah.blogspot.com
Signature · 1 line
http://www.fastmail.fm - And now for something completely different…
Quoted 9 lines · Komal Shah
Andrew/Tony/Richard,
This is a revised patch as per the review comments from the Andrew on thread:
http://lkml.org/lkml/2006/7/22/19
Please review it and give me the Ack if looks ok.
Hi Komal,
The driver needs to handle failures in input_register_device() and unwind initialization properly. Also you do not need to do double negation of the value when calling input_report_key() because it will do it for you.
Also you might consider setting up keycodetable, keycodesize, etc in the input device - this way you can change keymap at runtime via ioctls.
Signature · 1 line
Dmitry
Quoted 11 lines · --- Dmitry Torokhov
Hi Komal,
The driver needs to handle failures in
input_register_device()and unwind initialization properly. Also you do not need to do double negation of the value when callinginput_report_key()because it will do it for you.Also you might consider setting up keycodetable, keycodesize, etc in the input device - this way you can change keymap at runtime via ioctls.
Thanx for the review. I will update the driver and submit to list soon.
---Komal Shah
http://komalshah.blogspot.com/
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com