Skip to contentSkip to conversation

extents for ext4

PATCH Randy Dunlap 2 participants 2 messages Aug 15, 2006 VFS

lore
Share & tools
lore
#0 lore raw
Quoted 18 lines

Hi!

Quoted 14 lines
Quoted 4 lines

AM> - The existing comments could benefit from some rework by a AM> native English speaker.

could someone assist here, please?

See if this helps.
Patch applies on top of all ext4 patches from
http://ext2.sourceforge.net/48bitext3/patches/latest/.

include/linux/ext4_fs_extents.h +0 -0
@@ -22,29 +22,29 @@
 #include <linux/ext4_fs.h>
 
Quoted 13 lines

include/linux/ext4_fs_extents.h line 30

Quoted 11 lines
include/linux/ext4_fs_extents.h +4 -4
 /*
- * with AGRESSIVE_TEST defined capacity of index/leaf blocks
- * become very little, so index split, in-depth growing and
- * other hard changes happens much more often
- * this is for debug purposes only
+ * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks
+ * becomes very small, so index split, in-depth growing and
+ * other hard changes happen much more often.
+ * This is for debug purposes only.
  */
 #define AGRESSIVE_TEST_

Using _ for disabling is unusual/nasty. Can't we simply #undef it?

Yes, that's the right thing to do.
The ext4dev people should do that. :)

---
~Randy

#1 lore raw
Quoted 33 lines · Randy Dunlap
Quoted 18 lines

Hi!

Quoted 14 lines
Quoted 4 lines

AM> - The existing comments could benefit from some rework by a AM> native English speaker.

could someone assist here, please?

See if this helps.
Patch applies on top of all ext4 patches from
http://ext2.sourceforge.net/48bitext3/patches/latest/.

include/linux/ext4_fs_extents.h +0 -0
@@ -22,29 +22,29 @@
 #include <linux/ext4_fs.h>
 
Quoted 13 lines

include/linux/ext4_fs_extents.h line 30

Quoted 11 lines
include/linux/ext4_fs_extents.h +4 -4
 /*
- * with AGRESSIVE_TEST defined capacity of index/leaf blocks
- * become very little, so index split, in-depth growing and
- * other hard changes happens much more often
- * this is for debug purposes only
+ * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks
+ * becomes very small, so index split, in-depth growing and
+ * other hard changes happen much more often.
+ * This is for debug purposes only.
 */
 #define AGRESSIVE_TEST_

Using _ for disabling is unusual/nasty. Can't we simply #undef it?

Quoted 3 lines

Yes, that's the right thing to do.
The ext4dev people should do that. :)

Okey, I will fixed that. thanks.

Quoted 2 lines

---
~Randy