pam_namespace: add a new option for trusted programs to control unmount from pam_sm_close_session
PATCH 1/1 pam_namespace: add a new option for trusted programs to control unmount from pam_sm_close_session
This patch adds a new argument to pam_namespace. This new argument was needed to support trusted commands such as newrole that perform pam_open_session from a child process and pam_close_session from the parent. With this new argument, no_unmount_on_close, pam_sm_close_session will not unmount polyinstantiated directory.
Signed-off-by Janak Desai <[email protected]>
---
README.xml | 8 ++++++++ pam_namespace.8.xml | 19 +++++++++++++++++++ pam_namespace.c | 17 +++++++++++++++++ pam_namespace.h | 1 + 4 files changed, 45 insertions(+)
modules/pam_namespace/README.xml +8 -0
@@ -121,6 +121,14 @@ ARGUMENTS RECOGNIZED: the restrictive mode of 000. Using this option, an administrator can choose to ignore the mode of the instance parent. + no_unmount_on_close + For certain trusted programs such as newrole, open session + is called from a child process while the parent perfoms + close session and pam end functions. For these commands + use this option to instruct pam_close_session to not + unmount the bind mounted polyinstantiated directory in the + parent. + MODULE SERVICES PROVIDED: session open_session and close_session
modules/pam_namespace/pam_namespace.8.xml +19 -0
@@ -43,6 +43,9 @@ <arg choice="opt"> ignore_instance_parent_mode </arg> + <arg choice="opt"> + no_unmount_on_close + </arg> </cmdsynopsis> </refsynopsisdiv>
@@ -179,6 +182,22 @@ </listitem> </varlistentry> + <varlistentry> + <term> + <option>no_unmount_on_close</option> + </term> + <listitem> + <para> + For certain trusted programs such as newrole, open session + is called from a child process while the parent perfoms + close session and pam end functions. For these commands + use this option to instruct pam_close_session to not + unmount the bind mounted polyinstantiated directory in the + parent. + </para> + </listitem> + </varlistentry> + </variablelist> </refsect1>
modules/pam_namespace/pam_namespace.c +17 -0
@@ -1266,11 +1266,28 @@ PAM_EXTERN int pam_sm_close_session(pam_ idata.flags |=PAMNS_DEBUG ;if (strcmp (argv[i],"ignore_config_error" ) ==0 ) idata.flags |=PAMNS_IGN_CONFIG_ERR ; +if (strcmp (argv[i],"no_unmount_on_close" ) ==0 ) + idata.flags |=PAMNS_NO_UNMOUNT_ON_CLOSE ; }if (idata.flags &PAMNS_DEBUG )pam_syslog (idata.pamh,LOG_DEBUG ,"close_session - start" ); +/* +* For certain trusted programs such as newrole, open session +* is called from a child process while the parent perfoms +* close session and pam end functions. For these commands +* pam_close_session should not perform the unmount of the +* polyinstantiatied directory because it will result in +* undoing of parents polyinstantiatiaion. These commands +* will invoke pam_namespace with the "no_unmount_on_close" +* argument. +*/ +if (idata.flags &PAMNS_NO_UNMOUNT_ON_CLOSE ) { +pam_syslog (idata.pamh,LOG_DEBUG ,"close_session - sucessful" ); +return PAM_SUCCESS ; + } +/* * Lookup user and fill struct items */
modules/pam_namespace/pam_namespace.h +1 -0
@@ -86,6 +86,7 @@#define PAMNS_GEN_HASH 0x00002000/* Generate md5 hash for inst names */ #define PAMNS_IGN_CONFIG_ERR 0x00004000/* Ignore format error in conf file */ #define PAMNS_IGN_INST_PARENT_MODE 0x00008000/* Ignore instance parent mode */ +#define PAMNS_NO_UNMOUNT_ON_CLOSE 0x00010000/* no unmount at session close */ /* * Polyinstantiation method options, based on user, security context
--
This message was distributed to subscribers of the selinux mailing list. If you no longer wish to subscribe, send mail to [email protected] with the words "unsubscribe selinux" without quotes as the message.