Skip to contentSkip to conversation

BUG_ON cleanups in arch/i386

PATCH New Eric Sesterhenn 1 participant 1 message Sep 6, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 BUG_ON cleanups in arch/i386

hi,

this changes a couple of if() BUG(); constructs to BUG_ON(); so it can be safely optimized away.

arch/i386/kernel/cpu/common.c renamed from arch/i386/kernel/cpu/common.c.orig +1 -2
@@ -660,8 +660,7 @@ old_gdt:
 	 */
 	atomic_inc(&init_mm.mm_count);
 	current->active_mm = &init_mm;
-	if (current->mm)
-		BUG();
+	BUG_ON(current->mm);
 	enter_lazy_tlb(&init_mm, current);
 
 	load_esp0(t, thread);
./arch/i386/kernel/efi.c renamed from ./arch/i386/kernel/efi.c.orig +1 -2
@@ -498,8 +498,7 @@ void __init efi_enter_virtual_mode(void)
 		check_range_for_systab(md);
 	}
 
-	if (!efi.systab)
-		BUG();
+	BUG_ON(!efi.systab);
 
 	status = phys_efi_set_virtual_address_map(
 			memmap.desc_size * memmap.nr_map,
arch/i386/mm/discontig.c renamed from arch/i386/mm/discontig.c.orig +1 -2
@@ -152,8 +152,7 @@ static void __init find_max_pfn_node(int
 	 */
 	if (node_start_pfn[nid] > max_pfn)
 		node_start_pfn[nid] = max_pfn;
-	if (node_start_pfn[nid] > node_end_pfn[nid])
-		BUG();
+	BUG_ON(node_start_pfn[nid] > node_end_pfn[nid]);
 }
 
 /* Find the owning node for a pfn. */
arch/i386/mm/init.c renamed from arch/i386/mm/init.c.orig +1 -2
@@ -574,8 +574,7 @@ void __init mem_init(void)
 	int bad_ppro;
 
 #ifdef CONFIG_FLATMEM
-	if (!mem_map)
-		BUG();
+	BUG_ON(!mem_map);
 #endif
 	
 	bad_ppro = ppro_with_ram_bug();

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors