Skip to contentSkip to conversation

nomzomi: remove bogus cast

PATCH In review Alan Cox 3 participants 3 messages Sep 25, 2006 – Sep 26, 2006 Char and misc drivers

lore
Share & tools
lore

Alan Cox

author
#0 lore raw

PATCH 1/1 nomzomi: remove bogus cast

May as well go straight into the main tree

drivers/char/nozomi.c +1 -1
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c linux-2.6.18-mm1/drivers/char/nozomi.c
@@ -1225,7 +1225,7 @@
     }
 
     if ( !(dc = get_dc_by_pdev(dev_id)) )  {
-        ERR("Could not find device context from pci_dev: %d", (u32) dev_id);
+        ERR("Could not find device context from pci_dev: %p", dev_id);
         return IRQ_NONE;
     }
 
#1 lore raw
Quoted 2 lines · Alan Cox

May as well go straight into the main tree

Umm.

Great idea, but that file is not actually _in_ the main tree yet. I think your original patch to add it still lies in the -mm queue ;)

So send it to Andrew, or just re-send it once Andrew has patch-bombed me, ok? I'm too disorganized to keep track of it separately..

Linus

#2 lore raw
In reply to Alan Cox

Hi Alan,

Quoted 8 lines

May as well go straight into the main tree

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-mm1/drivers/char/nozomi.c linux-2.6.18-mm1/drivers/char/nozomi.c

drivers/char/nozomi.c line 1231

Quoted 8 lines
drivers/char/nozomi.c +1 -1
@@ -1225,7 +1225,7 @@
     }
 
     if ( !(dc = get_dc_by_pdev(dev_id)) )  {
-        ERR("Could not find device context from pci_dev: %d", (u32) dev_id);
+        ERR("Could not find device context from pci_dev: %p", dev_id);
         return IRQ_NONE;
     }
 

this driver needs more love than this ;)

Regards

Marcel