Skip to contentSkip to conversation

i2c: Warn on i2c client creation failure

PATCH New Greg KH 1 participant 1 message Sep 27, 2006 I2C

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 24/30 i2c: Warn on i2c client creation failure

From: Jean Delvare <khali at linux-fr.org>

i2c: Warn on i2c client creation failure

Warn when an i2c client creation fails. If we don't, the user will never know something wrong happened, as i2c client creation is typically called through an attach_adapter callback, those return value we currently ignore for technical reasons.

Signed-off-by Jean Delvare <khali at linux-fr.org>
Signed-off-by Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/i2c/i2c-core.c |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)
drivers/i2c/i2c-core.c +7 -2
index 88dd803..01233f0 100644
@@ -707,11 +707,16 @@ static int i2c_probe_address(struct i2c_
 
 	/* Finally call the custom detection function */
 	err = found_proc(adapter, addr, kind);
-
 	/* -ENODEV can be returned if there is a chip at the given address
 	   but it isn't supported by this chip driver. We catch it here as
 	   this isn't an error. */
-	return (err = -ENODEV) ? 0 : err;
+	if (err = -ENODEV)
+		err = 0;
+
+	if (err)
+		dev_warn(&adapter->dev, "Client creation failed at 0x%x (%d)\n",
+			 addr, err);
+	return err;
 }
 
 int i2c_probe(struct i2c_adapter *adapter,
Signature · 1 line
1.4.2.1