Remove unnecessary check in net/sunrpc/svcsock.c
Subsystems (4)
PATCH 1/1 Remove unnecessary check in net/sunrpc/svcsock.c
hi,
coverity spotted this one as possible dereference in the dprintk(), but since there is only one caller of svc_create_socket(), which always passes a valid sin, we dont need this check.
Signed-off-by Eric Sesterhenn <[email protected]>
net/sunrpc/svcsock.c renamed from net/sunrpc/svcsock.c.orig +6 -8
@@ -1393,14 +1393,12 @@ svc_create_socket(struct svc_serv *serv,if ((error =sock_create_kern (PF_INET , type, protocol, &sock)) <0 )return error; -if (sin !=NULL ) { -if (type ==SOCK_STREAM ) - sock->sk->sk_reuse =1 ;/* allow address reuse */ - error =kernel_bind (sock, (struct sockaddr *) sin, -sizeof (*sin)); -if (error <0 ) - goto bummer; - } +if (type ==SOCK_STREAM ) + sock->sk->sk_reuse =1 ;/* allow address reuse */ + error =kernel_bind (sock, (struct sockaddr *) sin, +sizeof (*sin)); +if (error <0 ) + goto bummer;if (protocol ==IPPROTO_TCP ) {if ((error =kernel_listen (sock,64 )) <0 )
From: Eric Sesterhenn <[email protected]>
Date: Wed, 27 Sep 2006 17:34:49 +0200
Quoted 5 lines
coverity spotted this one as possible dereference in the
dprintk(), but since there is only one caller ofsvc_create_socket(), which always passes a valid sin, we dont need this check.Signed-off-by Eric Sesterhenn <[email protected]>
Applied, thanks Eric.