rtc driver rtc-pcf8563 century bit inversed
PATCH 1/1 rtc driver rtc-pcf8563 century bit inversed
The century bit PCF8563_MO_C in the month register is misinterpreted. It is set to 1 for the 20th century and 0 for 21th, and the driver is expecting the opposite behavior.
Here is a small patch to address this issue.
Thanks for all the good work!
Jean-Baptiste Maneyrol
Teamlog - France
drivers/rtc/rtc-pcf8563.c +2 -2
@@ -95,7 +95,7 @@ tm->tm_wday = buf[PCF8563_REG_DW ] &0x07 ; tm->tm_mon =BCD2BIN (buf[PCF8563_REG_MO ] &0x1F ) -1 ;/* rtc mn 1-12 */ tm->tm_year =BCD2BIN (buf[PCF8563_REG_YR ]) - + (buf[PCF8563_REG_MO ] &PCF8563_MO_C ?100 :0 ); + + (buf[PCF8563_REG_MO ] &PCF8563_MO_C ?0 :100 ); dev_dbg(&client->dev, "%s: tm is secs=%d, mins=%d, hours=%d, " "mday=%d, mon=%d, year=%d, wday=%d\n",
@@ -135,7 +135,7 @@/* year and century */ buf[PCF8563_REG_YR ] =BIN2BCD (tm->tm_year %100 ); -if (tm->tm_year /100 ) +if (tm->tm_year <100 ) buf[PCF8563_REG_MO ] |=PCF8563_MO_C ; buf[PCF8563_REG_DW ] = tm->tm_wday &0x07 ;
Quoted 6 lines · On Thu, 28 Sep 2006 16:19:49 +0200 Jean-Baptiste Maneyrol…
The century bit
PCF8563_MO_Cin the month register is misinterpreted. It is set to 1 for the 20th century and 0 for 21th, and the driver is expecting the opposite behavior.Here is a small patch to address this issue.
Thanks for all the good work!
Thanks for spotting this, please fwd to
akpm for inclusion in -mm .
Acked-by Alessandro Zummo <[email protected]>
Signature · 6 lines
Best regards, Alessandro Zummo, Tower Technologies - Turin, Italy http://www.towertech.it