Skip to contentSkip to conversation

hdaps: Handle errors from

PATCH New Greg KH 1 participant 1 message Sep 28, 2006 Hardware monitoring

lore
Share & tools
lore

Greg KH

author
#0 lore raw

PATCH 4/39 hdaps: Handle errors from

From: Dmitry Torokhov <dtor at insightbb.com>

HDAPS: handle errors from input_register_device()

Signed-off-by Dmitry Torokhov <dtor at mail.ru>
Signed-off-by Jean Delvare <khali at linux-fr.org>
Signed-off-by Greg Kroah-Hartman <gregkh at suse.de>
---
 drivers/hwmon/hdaps.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
drivers/hwmon/hdaps.c +5 -1
index 42b6328..8e7b560 100644
@@ -587,7 +587,9 @@ static int __init hdaps_init(void)
 	input_set_abs_params(hdaps_idev, ABS_Y,
 			-256, 256, HDAPS_INPUT_FUZZ, HDAPS_INPUT_FLAT);
 
-	input_register_device(hdaps_idev);
+	ret = input_register_device(hdaps_idev);
+	if (ret)
+		goto out_idev;
 
 	/* start up our timer for the input device */
 	init_timer(&hdaps_timer);
@@ -598,6 +600,8 @@ static int __init hdaps_init(void)
 	printk(KERN_INFO "hdaps: driver successfully loaded.\n");
 	return 0;
 
+out_idev:
+	input_free_device(hdaps_idev);
 out_group:
 	sysfs_remove_group(&pdev->dev.kobj, &hdaps_attribute_group);
 out_device:
Signature · 1 line
1.4.2.1