check_/request_region fixes: sound/oss/pss.c
Subsystems (2)
PATCH 1/1 check_/request_region fixes: sound/oss/pss.c
Hi,
Attached patch is to get rid of check_region and replace with request_region.
Kevin
sound/oss/pss.c renamed from sound/oss/pss.c.orig +1 -1
@@ -677,7 +677,7 @@ static void configure_nonsound_component {printk (KERN_INFO "PSS: CDROM port not enabled.\n" ); } - else if(check_region(pss_cdrom_port, 2)) + else if(!request_region(pss_cdrom_port, 2, "PSS cdrom port")) {printk (KERN_ERR "PSS: CDROM I/O port conflict.\n" ); }
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 7 lines · Kevin Lo
Hi,
Attached patch is to get rid of
check_regionand replace withrequest_region.Kevin
Nope. This is wrong. You have to replace both check_region() and modify the call to request_region(). Look through the list for examples on how to do it.
Also don't send the patch as an attachment, just include it in your email. But make sure the lines don't wrap and the tabs are preserved.
regards,
dan carpenter
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors
Quoted 4 lines · Kevin Lo
Hi,
Attached patch is to get rid of
check_regionand replace withrequest_region.
Whoops, please ignore this patch since I sent the wrong one :-(
Quoted 2 lines
Kevin
Kevin
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors