Skip to contentSkip to conversation

remove some rsm psr.dt in ivt.S

PATCH In review Zou Nan hai 2 participants 3 messages Oct 17, 2006 – Oct 18, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove some rsm psr.dt in ivt.S

The rsm psr.dt in page_not_present, key_permission, iaccess_rights and daccess_right are not necessary.
Since there is no data access between those points to page_fault, and page_fault will enable psr.dt at the beginning.

arch/ia64/kernel/ivt.S +0 -8
@@ -1201,7 +1201,6 @@ END(dispatch_to_fault_handler)
 ENTRY(page_not_present)
 	DBG_FAULT(20)
 	mov r16=cr.ifa
-	rsm psr.dt
 	/*
 	 * The Linux page fault handler doesn't expect non-present pages to be in
 	 * the TLB.  Flush the existing entry now, so we meet that expectation.
@@ -1211,7 +1210,6 @@ ENTRY(page_not_present)
 	ptc.l r16,r17
 	;;
 	mov r31=pr
-	srlz.d
 	br.sptk.many page_fault
 END(page_not_present)
 
@@ -1221,10 +1219,8 @@ END(page_not_present)
 ENTRY(key_permission)
 	DBG_FAULT(21)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
 	;;
-	srlz.d
 	br.sptk.many page_fault
 END(key_permission)
 
@@ -1234,10 +1230,8 @@ END(key_permission)
 ENTRY(iaccess_rights)
 	DBG_FAULT(22)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
 	;;
-	srlz.d
 	br.sptk.many page_fault
 END(iaccess_rights)
 
@@ -1247,10 +1241,8 @@ END(iaccess_rights)
 ENTRY(daccess_rights)
 	DBG_FAULT(23)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
 	;;
-	srlz.d
 	br.sptk.many page_fault
 END(daccess_rights)
 
#1 lore raw
Quoted 24 lines · Kenneth W

Zou Nan hai wrote on Tuesday, October 17, 2006 3:10 PM

Quoted 1 line

The rsm psr.dt in page_not_present, key_permission, iaccess_rights

and

Quoted 2 lines

daccess_right are not necessary.
Since there is no data access between those points to page_fault,

and

Review END(page_not_present) · line 1225

Quoted 12 lines

page_fault will enable psr.dt at the beginning.

(quoted diff) +0 -2
@@ -1221,10 +1219,8 @@ END(page_not_present)
 ENTRY(key_permission)
      DBG_FAULT(21)
      mov r16=cr.ifa
-     rsm psr.dt
      mov r31=pr
      ;;
-     srlz.d
      br.sptk.many page_fault
 END(key_permission)

You can get rid of that stop bit too. Same for two other instances. And your changelog mentioned daccess_right, but patch missed that hunk.

Quoted 2 lines

- Ken

Ok, daccess_right hunk was in the patch...

arch/ia64/kernel/ivt.S +0 -12
@@ -1201,7 +1201,6 @@ END(dispatch_to_fault_handler)
 ENTRY(page_not_present)
 	DBG_FAULT(20)
 	mov r16=cr.ifa
-	rsm psr.dt
 	/*
 	 * The Linux page fault handler doesn't expect non-present pages to be in
 	 * the TLB.  Flush the existing entry now, so we meet that expectation.
@@ -1209,9 +1208,7 @@ ENTRY(page_not_present)
 	mov r17=PAGE_SHIFT<<2
 	;;
 	ptc.l r16,r17
-	;;
 	mov r31=pr
-	srlz.d
 	br.sptk.many page_fault
 END(page_not_present)
 
@@ -1221,10 +1218,7 @@ END(page_not_present)
 ENTRY(key_permission)
 	DBG_FAULT(21)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
-	;;
-	srlz.d
 	br.sptk.many page_fault
 END(key_permission)
 
@@ -1234,10 +1228,7 @@ END(key_permission)
 ENTRY(iaccess_rights)
 	DBG_FAULT(22)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
-	;;
-	srlz.d
 	br.sptk.many page_fault
 END(iaccess_rights)
 
@@ -1247,10 +1238,7 @@ END(iaccess_rights)
 ENTRY(daccess_rights)
 	DBG_FAULT(23)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
-	;;
-	srlz.d
 	br.sptk.many page_fault
 END(daccess_rights)
 
#2 lore raw
In reply to Zou Nan hai

Zou Nan hai wrote on Tuesday, October 17, 2006 3:10 PM

Quoted 6 lines

The rsm psr.dt in page_not_present, key_permission, iaccess_rights and daccess_right are not necessary.
Since there is no data access between those points to page_fault, and page_fault will enable psr.dt at the beginning.

arch/ia64/kernel/ivt.S END(page_not_present) · line 1225

Quoted 9 lines
arch/ia64/kernel/ivt.S +0 -2
@@ -1221,10 +1219,8 @@ END(page_not_present)
 ENTRY(key_permission)
 	DBG_FAULT(21)
 	mov r16=cr.ifa
-	rsm psr.dt
 	mov r31=pr
 	;;
-	srlz.d
 	br.sptk.many page_fault
 END(key_permission)

You can get rid of that stop bit too. Same for two other instances. And your changelog mentioned daccess_right, but patch missed that hunk.

- Ken