time_adjust cleared before use
PATCH 1/1 time_adjust cleared before use
Hi
I notice that the code which implements adjtime clears the time_adjust value before using it. The attached patch makes the obvious fix.
Jim Houston - Concurrent Computer Corp.
--
kernel/time/ntp.c +1 -1
@@ -161,9 +161,9 @@ void second_overflow(void) time_adjust +=MAX_TICKADJ ; tick_length -=MAX_TICKADJ_SCALED ; }else { - time_adjust =0 ; tick_length += (s64)(time_adjust *NSEC_PER_USEC /HZ ) <<TICK_LENGTH_SHIFT ; + time_adjust =0 ; } } }
Hi,
Quoted 15 lines · Jim Houston
Hi
I notice that the code which implements adjtime clears the
time_adjustvalue before using it. The attached patch makes the obvious fix.Jim Houston - Concurrent Computer Corp.
--
kernel/time/ntp.c +0
-0
kernel/time/ntp.c void second_overflow(void) · line 169
Quoted 10 lines
kernel/time/ntp.c +1
-1@@ -161,9 +161,9 @@ void second_overflow(void) time_adjust +=MAX_TICKADJ ; tick_length -=MAX_TICKADJ_SCALED ; }else { - time_adjust =0 ; tick_length += (s64)(time_adjust *NSEC_PER_USEC /HZ ) <<TICK_LENGTH_SHIFT ; + time_adjust =0 ; } } }
Acked-by Roman Zippel <[email protected]>
Thanks, that might also explain the other problem. Could you please sign it off and then it should go into 2.6.19.
bye, Roman
Quoted 6 lines · Roman Zippel
Quoted 3 lines · Jim Houston
I notice that the code which implements adjtime clears the
time_adjustvalue before using it. The attached patch makes the obvious fix.Acked-by Roman Zippel <[email protected]>
Signed-off-by Jim Houston <[email protected]>
kernel/time/ntp.c +1 -1
@@ -161,9 +161,9 @@ void second_overflow(void) time_adjust +=MAX_TICKADJ ; tick_length -=MAX_TICKADJ_SCALED ; }else { - time_adjust =0 ; tick_length += (s64)(time_adjust *NSEC_PER_USEC /HZ ) <<TICK_LENGTH_SHIFT ; + time_adjust =0 ; } } }