Add missing unlock in get_next_corpse()
Subsystems (2)
PATCH 1/1 Add missing unlock in get_next_corpse()
Add missing unlock in get_next_corpse() in nf_conntrack. It was missed during the removal of listhelp.h . Also remove an unneeded use of nf_ct_tuplehash_to_ctrack() in the same function.
Should be applied before 2.6.19 is released.
Signed-off-by Martin Josefsson <[email protected]>
--- net/netfilter/nf_conntrack_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/netfilter/nf_conntrack_core.c +2 -1
@@ -1520,9 +1520,10 @@ get_next_corpse(int (*iter)(struct nf_coif (iter (ct, data)) goto found; } +write_unlock_bh (&nf_conntrack_lock);return NULL ; found: -atomic_inc (&nf_ct_tuplehash_to_ctrack (h)->ct_general.use); +atomic_inc (&ct->ct_general.use);write_unlock_bh (&nf_conntrack_lock);return ct; }
Signature · 1 line
/Martin
Patrick McHardy
AppliedQuoted 5 lines · Martin Josefsson
Add missing unlock in
get_next_corpse()innf_conntrack. It was missed during the removal oflisthelp.h. Also remove an unneeded use ofnf_ct_tuplehash_to_ctrack()in the same function.Should be applied before 2.6.19 is released.
Applied, thanks for catching this.