Skip to contentSkip to conversation

Fix mask to stop AT91 SSC clock on shutdown

PATCH Applied Liam Girdwood 2 participants 2 messages Oct 31, 2006 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix mask to stop AT91 SSC clock on shutdown

This patch by Frank Mandarino and Hubert Kahlert fixes a bug in the AT91 SSC (i2s) shutdown code that would erroneously disable other AT91 peripheral clocks.

# HG changeset patch
# User [email protected]
# Date 1161951244 14400
# Node ID a8c5e404fd61fd6844b94d36efe544bec03d0b68 # Parent 24b6b107f951ce9198caaa99731dd0a9fbd08488 Fixed mask to stop SSC clock on shutdown.

Current code will stop other clocks, such as AIC and PIO, depending on the SSC used. Reported by Hubert Kahlert.

soc/at91/at91rm9200-i2s.c +1 -1
diff -r 24b6b107f951 -r a8c5e404fd61 soc/at91/at91rm9200-i2s.c
@@ -373,7 +373,7 @@ static void at91rm9200_i2s_shutdown(stru
 	if (!ssc_p->dir_mask) {
 		/* Shutdown the SSC clock. */
 		DBG("Stopping pid %d clock\n", ssc_p->pid);
-		at91_sys_write(AT91_PMC_PCDR, ssc_p->pid);
+		at91_sys_write(AT91_PMC_PCDR, 1<<ssc_p->pid);
 
 		if (ssc_p->initialized)
 			free_irq(ssc_p->pid, ssc_p);

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Applied
#1 lore raw

At Tue, 31 Oct 2006 13:16:51 +0000,

Quoted 8 lines · Liam Girdwood

This patch by Frank Mandarino and Hubert Kahlert fixes a bug in the AT91 SSC (i2s) shutdown code that would erroneously disable other AT91 peripheral clocks.

Applied to ALSA tree. Thanks.

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642