Skip to contentSkip to conversation

dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

PATCH In review Maninder Singh 2 participants 2 messages May 19, 2015 – May 21, 2015 dmaengine

lore
Share & tools
lore

Maninder Singh

author
#0 lore raw

PATCH 1/1 dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

EP-AA9D1F29B02341529D96C06444D8471D

Hi,
Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

Signed-off-by Maninder Singh <[email protected]>
Reviewed-by Vaneet Narang <[email protected]>
---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/dma/pl330.c +3 -1
index a7d9d30..7e27144 100644
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
Signature · 4 lines
1.7.1

Thanks 
Maninder Singhÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ¥Šwÿº{.nÇ+‰·¥Š{±þG«�éÿŠ{ayºʇڙë,j­¢f£¢·hš�ï�êÿ‘êçz_è®(­éšŽŠÝ¢j"�ú¶m§ÿÿ¾«þG«�éÿ¢¸?™¨è­Ú&£ø§~�á¶iO•æ¬z·švØ^¶m§ÿÿÃÿ¶ìÿ¢¸?–I¥
#1 lore raw
Quoted 1 line · Maninder Singh

EP-AA9D1F29B02341529D96C06444D8471D

Whats this, please sned patch ina proper format, git format-patch is your friend, use it

Quoted 3 lines

Hi,
Subject: [PATCH 1/1] dma/pl330.c : Initialize pl330 pointer after NULL check of pch pointer

patch title doesn't match expectations, use the right subsystem name, and also please explain why yoy are doing this

Quoted 32 lines
Signed-off-by Maninder Singh <[email protected]>
Reviewed-by Vaneet Narang <[email protected]>
---
 drivers/dma/pl330.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/dma/pl330.c +3 -1
index a7d9d30..7e27144 100644
@@ -2581,12 +2581,14 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 {
 	struct dma_pl330_desc *desc;
 	struct dma_pl330_chan *pch = to_pchan(chan);
-	struct pl330_dmac *pl330 = pch->dmac;
+	struct pl330_dmac *pl330;
 	int burst;
 
 	if (unlikely(!pch || !len))
 		return NULL;
 
+	pl330 = pch->dmac;
+
 	desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
 	if (!desc)
 		return NULL;
Signature · 4 lines
1.7.1

Thanks 
Maninder Singh¢éì¹»®&Þ~º&¶¬–+-±éݶ¥Šw®žË›±ÊâmçfiéàŠw¢žØ^n‡r¡ö¦zË?ëh™¨è­Ú&¢ø®G«?éh®(­éšŽŠÝ¢j"?ú¶m§ÿï?êäz¹Þ–Šàþf£¢·hšˆ§~ˆmš

Nice signature!

Signature · 1 line
~Vinod