Skip to contentSkip to conversation

Fix returned type in vtpm_get_backend() function call

PATCH In review Stefan Berger 2 participants 3 messages Nov 14, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix returned type in vtpm_get_backend() function call

Return a string from vtpm_get_backend() function call.

xen-unstable.hg/tools/libxen/include/xen_vtpm.h +1 -1
Index: root/xen-unstable.hg/tools/libxen/include/xen_vtpm.h
===================================================================
@@ -196,7 +196,7 @@ xen_vtpm_get_vm(xen_session *session, xe
  * Get the backend field of the given VTPM.
  */
 extern bool
-xen_vtpm_get_backend(xen_session *session, xen_vm *result, xen_vtpm vtpm);
+xen_vtpm_get_backend(xen_session *session, char **result, xen_vtpm vtpm);
 
 
 /**
xen-unstable.hg/tools/libxen/src/xen_vtpm.c +1 -1
Index: root/xen-unstable.hg/tools/libxen/src/xen_vtpm.c
===================================================================
@@ -170,7 +170,7 @@ xen_vtpm_get_vm(xen_session *session, xe
 
 
 bool
-xen_vtpm_get_backend(xen_session *session, xen_vm *result, xen_vtpm vtpm)
+xen_vtpm_get_backend(xen_session *session, char **result, xen_vtpm vtpm)
 {
     abstract_value param_values[] =
         {

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

#1 lore raw
Quoted 1 line · Stefan Berger

Return a string from vtpm_get_backend() function call.

I thought this field was meant to be a reference to the VM that represented the backend. Is that not the case?

Ewan.

#2 lore raw

[email protected] wrote on 11/14/2006 03:08:05 PM:

Quoted 5 lines · Stefan Berger
Quoted 2 lines

Return a string from vtpm_get_backend() function call.

I thought this field was meant to be a reference to the VM that

represented

Quoted 1 line

the backend. Is that not the case?

When creating the vTPM I am passing in the backend paramter as the name of the VM rather than its reference (uuid). So I wanted to change this to be symmetric. Should the backend parameter rather be the reference to the VM and translated to the name internally?

Stefan

Quoted 7 lines

Ewan.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel