split gfs2_dinode into on-disk and host variants [1/70]
Quoted 1 line
From
3ca68df6ee61e1a2034f3307b9edb9b3d87e5ca1Mon Sep 17 00:00:00 2001
From: Al Viro <[email protected]>
Date: Fri, 13 Oct 2006 20:11:25 -0400
Subject: [PATCH] [GFS2] split gfs2_dinode into on-disk and host variants
The latter is used as part of gfs2-private part of struct inode. It actually stores a lot of fields differently; for now the declaration is just cloned, inode field is swtiched and changes propagated.
--- fs/gfs2/inode.c | 4 ++-- fs/gfs2/ondisk.c | 6 +++-- include/linux/gfs2_ondisk.h | 48 ++++++++++++++++++++++++++++++++++++++++--- 3 files changed, 50 insertions(+), 8 deletions(-)
fs/gfs2/inode.c +2 -2
@@ -48,7 +48,7 @@ #include "util.h"void gfs2_inode_attr_in (struct gfs2_inode *ip) {struct inode *inode = &ip->i_inode; -struct gfs2_dinode *di = &ip->i_di; +struct gfs2_dinode_host *di = &ip->i_di; inode->i_ino = ip->i_num.no_addr;
@@ -98,7 +98,7 @@ void gfs2_inode_attr_in(struct gfs2_inodvoid gfs2_inode_attr_out (struct gfs2_inode *ip) {struct inode *inode = &ip->i_inode; -struct gfs2_dinode *di = &ip->i_di; +struct gfs2_dinode_host *di = &ip->i_di;gfs2_assert_withdraw (GFS2_SB (inode), (di->di_mode &S_IFMT ) == (inode->i_mode &S_IFMT )); di->di_mode = inode->i_mode;
fs/gfs2/ondisk.c +3 -3
@@ -153,7 +153,7 @@ void gfs2_quota_in(struct gfs2_quota *qu qu->qu_value =be64_to_cpu (str->qu_value); } -void gfs2_dinode_in (struct gfs2_dinode *di,const void *buf) +void gfs2_dinode_in (struct gfs2_dinode_host *di,const void *buf) {const struct gfs2_dinode *str = buf;
@@ -187,7 +187,7 @@ void gfs2_dinode_in(struct gfs2_dinode * } -void gfs2_dinode_out (const struct gfs2_dinode *di,void *buf) +void gfs2_dinode_out (const struct gfs2_dinode_host *di,void *buf) {struct gfs2_dinode *str = buf;
@@ -221,7 +221,7 @@ void gfs2_dinode_out(const struct gfs2_d } -void gfs2_dinode_print (const struct gfs2_dinode *di) +void gfs2_dinode_print (const struct gfs2_dinode_host *di) {gfs2_meta_header_print (&di->di_header);gfs2_inum_print (&di->di_num);
include/linux/gfs2_ondisk.h +45 -3
66 lines not on this page · raw message
Signature · 1 line
1.4.1
Review
Quoted 1 line
(quoted diff) +1
-0+ struct gfs2_dinode_host *di = &ip->i_di;
Please call this things just gfs2_inode. gfs_d(isk)_inode_host doesn't make any sense.
Hi,
Quoted 5 lines · Christoph Hellwig
Review
Quoted 1 line
(quoted diff) +1
-0+ struct gfs2_dinode_host *di = &ip->i_di;Please call this things just
gfs2_inode. gfs_d(isk)_inode_host doesn't make any sense.
Its not the final intention to keep this dinode_host structure (or indeed the other _host structures introduced by Al's patches), its a means to an end. Later patches in my inode shrinking series remove a number of the fields from it, so it is much smaller. I do want to do what you are requesting eventually, but I'm working on it a stage at a time now that Al has pushed me in the right direction,
Steve.