Skip to contentSkip to conversation

Mount problem with the GFS2 code [68/70]

GFS2 Steven Whitehouse 1 participant 1 message Nov 30, 2006 GFS2 file system

lore
Share & tools
lore
#0 lore raw

From 0da3585e1ef650d3224b4d6f9799558d1d99fa1e Mon Sep 17 00:00:00 2001
From: Srinivasa Ds <[email protected]>
Date: Thu, 30 Nov 2006 15:04:55 +0530
Subject: [PATCH] [GFS2] Mount problem with the GFS2 code

While mounting the gfs2 filesystem,our test team had a problem and we
got this error message.
=======================================================

GFS2: fsid=: Trying to join cluster "lock_nolock", "dasde1"
GFS2: fsid=dasde1.0: Joined cluster. Now mounting FS...
GFS2: not a GFS2 filesystem
GFS2: fsid=dasde1.0: can't read superblock: -22

==========================================================================
On debugging further we found that problem is while reading the super block(gfs2_read_super) and comparing the magic number in it. When I replace the submit_bio() call(present in gfs2_read_super) with the sb_getblk() and ll_rw_block(), mount operation succeded. On further analysis we found that before calling submit_bio(), bio->bi_sector was set to "sector" variable. This "sector" variable has the same value of bh->b_blocknr(block number). Hence there is a need to multiply this valuwith (blocksize >> 9)(9 because,sector size 2^9,samething happens in ll_rw_block also, before calling submit_bio()). So I have developed the patch which solves this problem. Please let me know your comments.
================================================================

---
 fs/gfs2/super.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/gfs2/super.c +1 -1
index 1408c5f..3b22727 100644
@@ -199,7 +199,7 @@ struct page *gfs2_read_super(struct supe
 		return NULL;
 	}
 
-	bio->bi_sector = sector;
+	bio->bi_sector = sector * (sb->s_blocksize >> 9);
 	bio->bi_bdev = sb->s_bdev;
 	bio_add_page(bio, page, PAGE_SIZE, 0);
 
Signature · 1 line
1.4.1