Skip to contentSkip to conversation

dmtimer.c omap1 register fix...

PATCH In review Matthew Percival 2 participants 4 messages Dec 8, 2006 – Dec 21, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dmtimer.c omap1 register fix...

G'Day,

When I went to use dmtimer7 it did not seem to work. I noticed that
the base addresses for dmtimers 7 and 8 were set wrong. A simple patch to correct a small error. Confirmed to fix the problem on an OSK.

-- Matthew

arch/arm/plat-omap/dmtimer.c +2 -2
@@ -90,8 +90,8 @@
 	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
 	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
 	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
-	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
-	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
+	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
+	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
 };
 
 #elif defined(CONFIG_ARCH_OMAP2)
#1 lore raw
Quoted 11 lines · Matthew Percival

G'Day,

When I went to use dmtimer7 it did not seem to work. I noticed that
the base addresses for dmtimers 7 and 8 were set wrong. A simple patch to correct a small error. Confirmed to fix the problem on an OSK.

-- Matthew

arch/arm/plat-omap/dmtimer.c line 97

Quoted 10 lines
arch/arm/plat-omap/dmtimer.c +2 -2
@@ -90,8 +90,8 @@
 	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
 	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
 	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
-	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
-	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
+	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
+	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
 };
 
 #elif defined(CONFIG_ARCH_OMAP2)

Good catch, can you please reply to this thread with your Signed-off-by?

Tony

#2 lore raw
Quoted 21 lines · Tony Lindgren
Quoted 20 lines · Matthew Percival

G'Day,

When I went to use dmtimer7 it did not seem to work. I noticed that
the base addresses for dmtimers 7 and 8 were set wrong. A simple patch to correct a small error. Confirmed to fix the problem on an OSK.

-- Matthew

arch/arm/plat-omap/dmtimer.c +2 -2
@@ -90,8 +90,8 @@
 	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
 	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
 	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
-	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
-	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
+	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
+	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
 };
 
Quoted 5 lines

arch/arm/plat-omap/dmtimer.c line 97

Quoted 1 line
arch/arm/plat-omap/dmtimer.c +0 -0
 #elif defined(CONFIG_ARCH_OMAP2)

Good catch, can you please reply to this thread with your Signed-off-by?

Tony

Signed-off-by Matthew Percival <matthew at capgo.com>
#3 lore raw
Quoted 22 lines · Matthew Percival
Quoted 21 lines · Tony Lindgren
Quoted 20 lines · Matthew Percival

G'Day,

When I went to use dmtimer7 it did not seem to work. I noticed that
the base addresses for dmtimers 7 and 8 were set wrong. A simple patch to correct a small error. Confirmed to fix the problem on an OSK.

-- Matthew

arch/arm/plat-omap/dmtimer.c +2 -2
@@ -90,8 +90,8 @@
 	{ .phys_base = 0xfffb2c00, .irq = INT_1610_GPTIMER4 },
 	{ .phys_base = 0xfffb3400, .irq = INT_1610_GPTIMER5 },
 	{ .phys_base = 0xfffb3c00, .irq = INT_1610_GPTIMER6 },
-	{ .phys_base = 0xfffb4400, .irq = INT_1610_GPTIMER7 },
-	{ .phys_base = 0xfffb4c00, .irq = INT_1610_GPTIMER8 },
+	{ .phys_base = 0xfffb7400, .irq = INT_1610_GPTIMER7 },
+	{ .phys_base = 0xfffbd400, .irq = INT_1610_GPTIMER8 },
 };
 
Quoted 7 lines
Quoted 5 lines

arch/arm/plat-omap/dmtimer.c line 97

Quoted 1 line
arch/arm/plat-omap/dmtimer.c +0 -0
 #elif defined(CONFIG_ARCH_OMAP2)

Good catch, can you please reply to this thread with your Signed-off-by?

Tony

Signed-off-by Matthew Percival <matthew at capgo.com>

Thanks, pushing today.

Tony