Skip to contentSkip to conversation

rethink removal of xattr syscall stubs (for now)

PATCH In review Nathan Scott 4 participants 6 messages Dec 19, 2006 – Dec 20, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rethink removal of xattr syscall stubs (for now)

Hi,

It turns out (*cough*) that we use an export file with libattr, that I completely forgot about, which specifies the *xattr calls as part of the ATTR_1 interface. This patch reverts the syscall stub removal patch from before, includes Lennerts patch to fix the original problem ARM EABI, and I'll go think some more about how to properly fix this (I think we'll need an ATTR_2 interface in the end here, Andreas?)

Please apply as an interim fix to the original problem and to the accidental new problems its caused, and I'll push through a new patch in the new year.

cheers.

Signature · 1 line
Nathan
VERSION +1 -1
Index: attr/VERSION
===================================================================
@@ -3,5 +3,5 @@
 #
 PKG_MAJOR=2
 PKG_MINOR=4
-PKG_REVISION=35
+PKG_REVISION=36
 PKG_BUILD=0
debian/changelog +8 -0
Index: attr/debian/changelog
===================================================================
@@ -1,3 +1,11 @@
+attr (2.4.36-1) unstable; urgency=high
+
+  * New upstream release
+  * Reinstate xattr syscall entry points (closes: #403585)
+  * Fix ARM EABI issue differently, thanks to Lennert Buytenhek.
+
+ -- Nathan Scott <[email protected]>  Tue, 19 Dec 2006 09:46:05 +1100
+
 attr (2.4.35-1) unstable; urgency=low
 
   * New upstream release
doc/CHANGES +6 -0
Index: attr/doc/CHANGES
===================================================================
@@ -1,3 +1,9 @@
+attr-2.4.36 (19 December 2006)
+	- Reinstate xattr syscall entry points (these symbols are
+	  explicitly exported from the library - d'oh!).
+	- Fix the original ARM EABI issue a different way, thanks
+	  to Lennert Buytenhek.
+
 attr-2.4.35 (8 December 2006)
 	- Remove system call stubs from libattr, we always defer to
 	  the libc interfaces in this day and age.  Removes a SIGILL
libattr/Makefile +6 -0
Index: attr/libattr/Makefile
===================================================================
@@ -15,6 +15,12 @@ LT_AGE = 1
 CFILES = libattr.c attr_copy_fd.c attr_copy_file.c attr_copy_check.c
 HFILES = libattr.h
 
+ifeq ($(PKG_PLATFORM),linux)
+CFILES += syscalls.c
+else
+LSRCFILES = syscalls.c
+endif
+
 LCFLAGS = -include libattr.h
 
 default: $(LTLIBRARY)
libattr/syscalls.c new file +263 -0

263 lines not on this page · raw message

#1 lore raw
Quoted 10 lines · Nathan Scott

Hi,

It turns out (*cough*) that we use an export file with libattr, that I completely forgot about, which specifies the *xattr calls as part of the ATTR_1 interface. This patch reverts the syscall stub removal patch from before, includes Lennerts patch to fix the original problem ARM EABI, and I'll go think some more about how to properly fix this (I think we'll need an ATTR_2 interface in the end here, Andreas?)

Quoted 3 lines

Please apply as an interim fix to the original problem and to the accidental new problems its caused, and I'll push through a new patch in the new year.

There is a way to re-export symbols you imported from another library with symbol versioning. That how for example libpthread works on recent Solaris versions. I'll find out how exactly that should be implemented.

#2 lore raw

On Tue, 2006-12-19 at 10:05 +0000, Christoph Hellwig wrote:

| > Please apply as an interim fix to the original problem and to
| > the accidental new problems its caused, and I'll push through a
| > new patch in the new year.
| 
| There is a way to re-export symbols you imported from another
| library with symbol versioning.  That how for example libpthread
| works on recent Solaris versions.  I'll find out how exactly that
| should be implemented.

Ah, that sounds ideal - thanks!

Signature · 1 line
Nathan
#3 lore raw
Quoted 11 lines · Nathan Scott

On Tue, 2006-12-19 at 10:05 +0000, Christoph Hellwig wrote:

| > Please apply as an interim fix to the original problem and to
| > the accidental new problems its caused, and I'll push through a
| > new patch in the new year.
| | There is a way to re-export symbols you imported from another
| library with symbol versioning.  That how for example libpthread
| works on recent Solaris versions.  I'll find out how exactly that
| should be implemented.

Ah, that sounds ideal - thanks!

Nathan, do you still need your patch applied or will you look into this new approach instead?

Lachlan

#4 lore raw
Quoted 11 lines · Lachlan McIlroy
Quoted 10 lines · Nathan Scott

On Tue, 2006-12-19 at 10:05 +0000, Christoph Hellwig wrote:

| > Please apply as an interim fix to the original problem and to
| > the accidental new problems its caused, and I'll push through a
| > new patch in the new year.
| 
| There is a way to re-export symbols you imported from another
| library with symbol versioning.  That how for example libpthread
| works on recent Solaris versions.  I'll find out how exactly that
| should be implemented.
Quoted 6 lines
Quoted 2 lines

Ah, that sounds ideal - thanks!

Nathan, do you still need your patch applied or will you look into this new approach instead?

The patch needs to be applied, thanks. At a later date we'll fix it differently, but that will take some time.

cheers.

Signature · 1 line
Nathan
#5 lore raw
Quoted 27 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Nathan Scott
Sent: Thursday, 21 December 2006 8:41 AM
To: [email protected]
Cc: Christoph Hellwig; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] rethink removal of xattr syscall stubs (for now)

Quoted 4 lines · Lachlan McIlroy
Quoted 3 lines · Nathan Scott

On Tue, 2006-12-19 at 10:05 +0000, Christoph Hellwig wrote:
| > Please apply as an interim fix to the original problem and to | > the accidental new problems its caused, and I'll push

through a

Quoted 5 lines
Quoted 5 lines
| > new patch in the new year.
| 
| There is a way to re-export symbols you imported from another
| library with symbol versioning.  That how for example libpthread
| works on recent Solaris versions.  I'll find out how 

exactly that

Quoted 5 lines
Quoted 4 lines

| should be implemented.

Ah, that sounds ideal - thanks!

Quoted 6 lines
Quoted 3 lines

Nathan, do you still need your patch applied or will you look into this new approach instead?

The patch needs to be applied, thanks. At a later date we'll fix it differently, but that will take some time.

I applied Nathan's patch yesterday.