Skip to contentSkip to conversation

min/max removal done?

KJ Steve Fox 1 participant 1 message Dec 19, 2006 Kernel janitors

lore
Share & tools
lore

Steve Fox

author
#0 lore raw

I was looking at the TODO and saw the hand-coded MIN/MAX removal listed. But it looks like Amol Lad's patch from September must have already gotten in?

[drfickle@flooterbu linux-2.6]$ grep -r "^#define MAX(" *
fs/xfs/linux-2.6/xfs_linux.h:#define MAX(a,b) (max(a,b))
scripts/kconfig/lxdialog/dialog.h:#define MAX(x,y) (x > y ? x : y) [drfickle@flooterbu linux-2.6]$ grep -r "^#define MIN(" * arch/um/drivers/mconsole_user.c:#define MIN(a,b) ((a)<(b) ? (a):(b))
fs/xfs/linux-2.6/xfs_linux.h:#define MIN(a,b) (min(a,b))
scripts/kconfig/lxdialog/dialog.h:#define MIN(x,y) (x < y ? x : y)

The macros in fs/xfs/linux-2.6/xfs_linux.h simply call the new 'good' macros.

arch/um/drivers/mconsole_user.c is some sort of user-space thingy?

scripts/kconfig/lxdialog/dialog.h shouldn't be of concern.

Can this item be crossed off the TODO list?

Signature · 6 lines
Steve Fox
IBM Linux Technology Center
_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors