Skip to contentSkip to conversation

: definion, code, and use of new SCSI ML host status DID_COND_REQUEUE

PATCH In review Edward Goggin 2 participants 5 messages Feb 2, 2007 SCSI

lore
Share & tools
lore
#0 lore raw

cover : definion, code, and use of new SCSI ML host status DID_COND_REQUEUE

Patch Set Summary:

1 Define new SCSI ML host status DID_COND_REQUEUE and
add its handling code to scsi_decide_disposition. Scsi_decide_disposition returns ADD_TO_MLQUEUE IFF not REQ_FAILFAST.

2 Return DID_COND_REQUEUE instead of DID_BUS_BUSY host status
in MPT fusion driver when IOC status is SUCCESS and scsi status is busy.

#1 lore raw
Quoted 10 lines · Edward Goggin

Patch Set Summary:

1 Define new SCSI ML host status DID_COND_REQUEUE and
add its handling code to scsi_decide_disposition. Scsi_decide_disposition returns ADD_TO_MLQUEUE IFF not REQ_FAILFAST.

2 Return DID_COND_REQUEUE instead of DID_BUS_BUSY host status
in MPT fusion driver when IOC status is SUCCESS and scsi status is busy.

Please, no.

In the first place, as I already said on the previous thread, I don't think the driver should be interpreting the BUSY return.

Secondly, the original problem was with fibre devices which seemed to want FAILFAST on BUSY (which looks very bogus to me), but no-one asked for this behaviour to be preserved. The original bug report:

"When a target device responds with BUSY status, the MPT driver was
sending DID_OK to the SCSI mid layer, which caused the IO to be retried indefinitely betweenthe mid layer and the driver. By changing the driver return status to DID_BUS_BUSY, the target BUSY status can now flow through the mid layer to an upper layer Failover driver, whichwill manage the I/O timeout."

is about behaviour which is now fixed (BUSY is retried for the command's maximum lifetime but no longer).

Thirdly, the VMware issue was that the fibre fix was causing your implementation to time out too fast.

The solution, then, as I said previously should simply be to pass the BUSY status up unmodified from the fusion driver.

James

#2 lore raw
Quoted 29 lines · James Bottomley
Quoted 10 lines · Edward Goggin

Patch Set Summary:

1 Define new SCSI ML host status DID_COND_REQUEUE and
add its handling code to scsi_decide_disposition. Scsi_decide_disposition returns ADD_TO_MLQUEUE IFF not REQ_FAILFAST.

2 Return DID_COND_REQUEUE instead of DID_BUS_BUSY host status
in MPT fusion driver when IOC status is SUCCESS and scsi status is busy.

Please, no.

In the first place, as I already said on the previous thread, I don't think the driver should be interpreting the BUSY return.

Secondly, the original problem was with fibre devices which seemed to want FAILFAST on BUSY (which looks very bogus to me), but no-one asked for this behaviour to be preserved. The original bug report:

"When a target device responds with BUSY status, the MPT driver was
sending DID_OK to the SCSI mid layer, which caused the IO to be retried indefinitely betweenthe mid layer and the driver. By changing the driver return status to DID_BUS_BUSY, the target BUSY status can now flow through the mid layer to an upper layer Failover driver, whichwill manage the I/O timeout."

Quoted 9 lines

is about behaviour which is now fixed (BUSY is retried for the command's maximum lifetime but no longer).

Thirdly, the VMware issue was that the fibre fix was causing your implementation to time out too fast.

The solution, then, as I said previously should simply be to pass the BUSY status up unmodified from the fusion driver.

That solution doesn't work for the RDAC/MPP driver as the BUSY status handler retries indefinitely. We need a solution which works for both a bare metal host running RDAC/MPP which for this use case, wants to get control over the failed command ASAP and a VMware host which may need to retry longer than DID_BUS_BUSY currently allows for.

I'll let the LSI/Engenio people comment further on their needs.

Quoted 4 lines

James

#3 lore raw
Quoted 5 lines · Edward Goggin

That solution doesn't work for the RDAC/MPP driver as the BUSY status handler retries indefinitely. We need a solution which works for both a bare metal host running RDAC/MPP which for this use case, wants to get control over the failed command ASAP and a VMware host which may need to retry longer than DID_BUS_BUSY currently allows for.

No it doesn't, not any longer... the mid-layer retries for the command up to its timeout before failing. That's the point about questioning the validity of the original problem.

James

#4 lore raw
Quoted 7 lines · James Bottomley
Quoted 5 lines · Edward Goggin

That solution doesn't work for the RDAC/MPP driver as the BUSY status handler retries indefinitely. We need a solution which works for both a bare metal host running RDAC/MPP which for this use case, wants to get control over the failed command ASAP and a VMware host which may need to retry longer than DID_BUS_BUSY currently allows for.

Quoted 7 lines

No it doesn't, not any longer... the mid-layer retries for the command up to its timeout before failing. That's the point about questioning the validity of the original problem.

James

I think I see your argument ... retries for BUSY and all other scsi/host status's are limited by the code in scsi_softirq_done which filters the disposition returned by scsi_decide_disposition, so no status will yield an indefinite retry.

Not clear if that's soon enough for RDAC/MPP. For the VMware case, it appears to allow an additional 30 seconds (beyond what DID_BUSY_BUSY would allow) for a retry.