Skip to contentSkip to conversation

Fix memory initialization on MPC8349E-mITX

PATCH New Timur Tabi 4 participants 6 messages Apr 30, 2007 – May 4, 2007

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 Fix memory initialization on MPC8349E-mITX

Define CFG_DDR_SDRAM_CLK_CNTL for the MPC8349E-mITX and MPC8349E-mITX-GP. This allows ddr->sdram_clk_cntl to be properly initialized. This is necessary on some ITX boards, notably those with a revision 3.1 CPU.

Also change spd_sdram() in cpu/mpc83xx/spd_sdram.c to not write anything into ddr->sdram_clk_cntl if CFG_DDR_SDRAM_CLK_CNTL is not defined.

Signed-off-by Timur Tabi <[email protected]>

---

This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards. It's been tested on all 83xx platforms that use SPD.

 board/mpc8349itx/mpc8349itx.c |    3 +--
 cpu/mpc83xx/spd_sdram.c       |    5 -----
 include/configs/MPC8349ITX.h  |    3 +++
 3 files changed, 4 insertions(+), 7 deletions(-)
board/mpc8349itx/mpc8349itx.c +1 -2
index 2b3ded1..178b1d3 100644
@@ -80,8 +80,7 @@ int fixed_sdram(void)
 	im->ddr.sdram_interval =
 	    (0x0410 << SDRAM_INTERVAL_REFINT_SHIFT) | (0x0100 <<
 						       SDRAM_INTERVAL_BSTOPRE_SHIFT);
-	im->ddr.sdram_clk_cntl =
-	    DDR_SDRAM_CLK_CNTL_SS_EN | DDR_SDRAM_CLK_CNTL_CLK_ADJUST_05;
+	im->ddr.sdram_clk_cntl = CFG_DDR_SDRAM_CLK_CNTL;
 
 	udelay(200);
cpu/mpc83xx/spd_sdram.c +0 -5
index d9b8753..2f5f9a3 100644
@@ -693,11 +693,6 @@ long int spd_sdram()
 
 #ifdef CFG_DDR_SDRAM_CLK_CNTL	/* Optional platform specific value */
 	ddr->sdram_clk_cntl = CFG_DDR_SDRAM_CLK_CNTL;
-#else
-	/* SS_EN = 0, source synchronous disable
-	 * CLK_ADJST = 0, MCK/MCK# is launched aligned with addr/cmd
-	 */
-	ddr->sdram_clk_cntl = 0x00000000;
 #endif
 	debug("DDR:sdram_clk_cntl=0x%08x\n", ddr->sdram_clk_cntl);
include/configs/MPC8349ITX.h +3 -0
index 37bbfb3..906339e 100644
@@ -154,6 +154,9 @@
 #define CFG_MEMTEST_START	0x1000		/* memtest region */
 #define CFG_MEMTEST_END		0x2000
 
+#define CFG_DDR_SDRAM_CLK_CNTL	(DDR_SDRAM_CLK_CNTL_SS_EN | \
+				DDR_SDRAM_CLK_CNTL_CLK_ADJUST_05)
+
 #ifdef CONFIG_HARD_I2C
 #define CONFIG_SPD_EEPROM		/* use SPD EEPROM for DDR setup*/
 #endif
Signature · 1 line
1.5.0.2.260.g2eb065
#1 lore raw

PATCH 1/1 Fix memory initialization on MPC8349E-mITX

Quoted 3 lines · In message <[email protected]> you wrote:

This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards. It's been tested on all 83xx platforms that use SPD.

Please use a more meaningful patch description. You may have a way to check what "bug 517" means, but I don't.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"If you are afraid of loneliness, don't marry."             - Chekhov
author
#2 lore raw

PATCH 1/1 Fix memory initialization on MPC8349E-mITX

Quoted 6 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:

This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards. It's been tested on all 83xx platforms that use SPD.

Please use a more meaningful patch description. You may have a way to check what "bug 517" means, but I don't.

That wasn't a description, that was a comment. It's located under the ---, so it won't appear in the git log.

Signature · 2 lines
Timur Tabi
Linux Kernel Developer @ Freescale
#3 lore raw

PATCH 1/1 Fix memory initialization on MPC8349E-mITX

Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 6 lines · Wolfgang Denk
Quoted 2 lines · In message <[email protected]> you wrote:

This patch fixes bug 517 and fixes problems with some MPC8349E-mITX boards. It's been tested on all 83xx platforms that use SPD.

Please use a more meaningful patch description. You may have a way to check what "bug 517" means, but I don't.

That wasn't a description, that was a comment. It's located under the ---, so it won't appear in the git log.

Please use a more meaningful comment, then.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,    CEO: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Like winter snow on summer lawn, time past is time gone.