Skip to contentSkip to conversation

kernel option CONFIG_USB_HIDINPUT_POWERBOOK description update

PATCH In review Noèl Köthe 2 participants 4 messages May 2, 2007 – May 7, 2007 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel option CONFIG_USB_HIDINPUT_POWERBOOK description update

Hello together,

The description of this option needs to be extended to be correct:)

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 renamed from usr/src/linux-2.6.21/drivers/usb/input/Kconfig 2007-04-27 18:02:46.000000000 +0200 +2 -2
@@ -28,12 +28,12 @@
        depends on USB_HID && INPUT=n
 
 config USB_HIDINPUT_POWERBOOK
-       bool "Enable support for iBook/PowerBook special keys"
+       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro special keys"
        default n
        depends on USB_HID
        help
          Say Y here if you want support for the special keys (Fn, Numlock) on
-         Apple iBooks and PowerBooks.
+         Apple iBooks, PowerBooks, MacBooks and MacBook Pro's.
 
          If unsure, say N.
 

This option is needed on the Apple Intel Laptops, too.
I would suggest to rename USB_HIDINPUT_POWERBOOK because its needed on Apple Laptops. Maybe USB_HIDINPUT_APPLELAPTOPS or something like this. Is a renaming patch for this welcome?

Thanks for your answer/applying.:)

Signature · 2 lines
Noèl Köthe <noel debian.org>
Debian GNU/Linux, www.debian.org
#1 lore raw

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 line 31

Quoted 9 lines · No?l Köthe

The description of this option needs to be extended to be correct:)

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 renamed from usr/src/linux-2.6.21/drivers/usb/input/Kconfig 2007-04-27 18:02:46.000000000 +0200 +1 -1
@@ -28,12 +28,12 @@
        depends on USB_HID && INPUT=n
 
 config USB_HIDINPUT_POWERBOOK
-       bool "Enable support for iBook/PowerBook special keys"
+       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro special keys"

Hi,

I will apply this into my tree, thanks.

Quoted 4 lines

This option is needed on the Apple Intel Laptops, too. I would suggest to rename USB_HIDINPUT_POWERBOOK because its needed on Apple Laptops. Maybe USB_HIDINPUT_APPLELAPTOPS or something like this. Is a renaming patch for this welcome?

The problem here is backwards compatibility - if we would like to do the change in a consistent way, we should rename all the places which (for historic reasons) mention powerbook only. Unfortunately this would also require renaming the module parameter hid_pb_fnmode, which might be a little too intrusive with respect to maintaining backward compatibility in userspace (ok, we have already been fiddling with this parameter anyway during the usbhid code split, but anyway).

If you would care to make the patch which maintains backwards compatibility (for example by aliasing the variable pb_fnmode behing two module parameters), that might probably be ok.

Thanks,

Signature · 1 line
Jiri Kosina
#2 lore raw

Am Donnerstag, den 03.05.2007, 09:56 +0200 schrieb Jiri Kosina:

Hello Jiri,

Quoted 7 lines

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 line 31

Quoted 5 lines

The description of this option needs to be extended to be correct:)

config USB_HIDINPUT_POWERBOOK

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 renamed from usr/src/linux-2.6.21/drivers/usb/input/Kconfig 2007-04-27 18:02:46.000000000 +0200 +1 -1
-       bool "Enable support for iBook/PowerBook special keys"
+       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro special keys"

I will apply this into my tree, thanks.

Great thanks. Does this mean it will go into your tree and then into the mainline kernel, or is there an additional step needed?

Quoted 13 lines
Quoted 4 lines

This option is needed on the Apple Intel Laptops, too. I would suggest to rename USB_HIDINPUT_POWERBOOK because its needed on Apple Laptops. Maybe USB_HIDINPUT_APPLELAPTOPS or something like this. Is a renaming patch for this welcome?

The problem here is backwards compatibility - if we would like to do the change in a consistent way, we should rename all the places which (for historic reasons) mention powerbook only. Unfortunately this would also require renaming the module parameter hid_pb_fnmode, which might be a little too intrusive with respect to maintaining backward compatibility in userspace (ok, we have already been fiddling with this parameter anyway during the usbhid code split, but anyway).

Quoted 3 lines

If you would care to make the patch which maintains backwards compatibility (for example by aliasing the variable pb_fnmode behing two module parameters), that might probably be ok.

I understand. I will try.

Signature · 2 lines
Noèl Köthe <noel debian.org>
Debian GNU/Linux, www.debian.org
#3 lore raw
Quoted 6 lines · No?l Köthe
Quoted 4 lines

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 line 31

Quoted 3 lines

config USB_HIDINPUT_POWERBOOK

Kconfig.new 2007-05-02 16:47:56.000000000 +0200 renamed from usr/src/linux-2.6.21/drivers/usb/input/Kconfig 2007-04-27 18:02:46.000000000 +0200 +1 -1
-       bool "Enable support for iBook/PowerBook special keys"
+       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro special keys"

I will apply this into my tree, thanks.

Great thanks. Does this mean it will go into your tree and then into the mainline kernel, or is there an additional step needed?

No further steps needed on your side. Applied, thanks,

Signature · 1 line
Jiri Kosina