Skip to contentSkip to conversation

fix bus matching

MCA James Bottomley 1 participant 1 message May 3, 2007

lore
Share & tools
lore
#0 lore raw

There's a bug in the MCA bus matching algorithm in that it promotes from signed short to int before comparing with the actual id and does sign extension on anything > 0x7fff (which means that pos ids > 0x7fff never get correctly matched).

---

drivers/mca/mca-bus.c +1 -1
index da862e4..a70fe00 100644
@@ -47,7 +47,7 @@ static int mca_bus_match (struct device *dev, struct device_driver *drv)
 {
 	struct mca_device *mca_dev = to_mca_device (dev);
 	struct mca_driver *mca_drv = to_mca_driver (drv);
-	const short *mca_ids = mca_drv->id_table;
+	const unsigned short *mca_ids = mca_drv->id_table;
 	int i;
 
 	if (!mca_ids)