is_power_of_2-rtc/rtc-s3c.c

PATCH New vignesh babu 1 participant 1 message Jun 12, 2007

Subsystems (2)

Kernel janitors Real time clock (RTC)

lore

Share & tools

lore

vignesh babu

author

2007-06-12 05:36 UTC #0 lore raw

PATCH 1/1 is_power_of_2-rtc/rtc-s3c.c

Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2

Signed-off-by vignesh babu <[email protected]>

---

drivers/rtc/rtc-s3c.c +2 -1

index 54b6130..e20bd6f 100644
@@ -20,6 +20,7 @@
 #include <linux/rtc.h>
 #include <linux/bcd.h>
 #include <linux/clk.h>
+#include <linux/log2.h>
 
 #include <asm/hardware.h>
 #include <asm/uaccess.h>

@@ -311,7 +312,7 @@ static int s3c_rtc_ioctl(struct device *dev,
 	case RTC_IRQP_SET:
 		/* check for power of 2 */
 
-		if ((arg & (arg-1)) != 0 || arg < 1) {
+		if (!is_power_of_2(arg)) {
 			ret = -EINVAL;
 			goto exit;
 		}

Signature · 8 lines

Vignesh Babu BM 
_____________________________________________________________ 
"Why is it that every time I'm with you, makes me believe in magic?"

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors