Skip to contentSkip to conversation

FSL I2C driver programs the two I2C busses differently

PATCH New Timur Tabi 2 participants 2 messages Jul 3, 2007

lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH 1/1 FSL I2C driver programs the two I2C busses differently

The i2c_init() function in fsl_i2c.c programs the two I2C busses differently. The second I2C bus has its slave address programmed incorrectly and is missing a 5-us delay.

Signed-off-by Timur Tabi <[email protected]>
---
 drivers/fsl_i2c.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/fsl_i2c.c +2 -1
index ebae5af..22485ea 100644
@@ -69,9 +69,10 @@ i2c_init(int speed, int slaveadd)
 	dev = (struct fsl_i2c *) (CFG_IMMR + CFG_I2C2_OFFSET);
 
 	writeb(0, &dev->cr);			/* stop I2C controller */
+	udelay(5);				/* let it shutdown in peace */
 	writeb(0x3F, &dev->fdr);		/* set bus speed */
 	writeb(0x3F, &dev->dfsrr);		/* set default filter */
-	writeb(slaveadd, &dev->adr);		/* write slave address */
+	writeb(slaveadd << 1, &dev->adr);	/* write slave address */
 	writeb(0x0, &dev->sr);			/* clear status register */
 	writeb(I2C_CR_MEN, &dev->cr);		/* start I2C controller */
 #endif	/* CFG_I2C2_OFFSET */
Signature · 1 line
1.5.0.2.260.g2eb065
#1 lore raw

PATCH 1/1 FSL I2C driver programs the two I2C busses differently

Quoted 5 lines · Timur Tabi

The i2c_init() function in fsl_i2c.c programs the two I2C busses differently. The second I2C bus has its slave address programmed incorrectly and is missing a 5-us delay.

Signed-off-by Timur Tabi <[email protected]>
Acked-by Grant Likely <[email protected]>

g.

Quoted 34 lines
---
 drivers/fsl_i2c.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/fsl_i2c.c +2 -2
index ebae5af..22485ea 100644
@@ -69,9 +69,10 @@ i2c_init(int speed, int slaveadd)
        dev = (struct fsl_i2c *) (CFG_IMMR + CFG_I2C2_OFFSET);
 
        writeb(0, &dev->cr);                    /* stop I2C controller */
+       udelay(5);                              /* let it shutdown in peace */
        writeb(0x3F, &dev->fdr);                /* set bus speed */
        writeb(0x3F, &dev->dfsrr);              /* set default filter */
-       writeb(slaveadd, &dev->adr);            /* write slave address */
+       writeb(slaveadd << 1, &dev->adr);       /* write slave address */
        writeb(0x0, &dev->sr);                  /* clear status register */
        writeb(I2C_CR_MEN, &dev->cr);           /* start I2C controller */
 #endif /* CFG_I2C2_OFFSET */
--

1.5.0.2.260.g2eb065

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users

Signature · 4 lines
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195