Skip to contentSkip to conversation

maps2-move-the-page-walker-code-to-lib.patch

DISCUSSION Rusty Russell 4 participants 6 messages Jul 8, 2007 – Jul 17, 2007

lore
Share & tools
lore
#0 lore raw
Quoted 1 line · Matt

This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir. You can use "lib-y += pagewalk.o" there, and it seems to work as well as doing it in lib.

Cheers,
Rusty.

#1 lore raw
Quoted 7 lines · Rusty Russell
Quoted 1 line · Matt

This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir. You can use "lib-y += pagewalk.o" there, and it seems to work as well as doing it in lib.

+1 from me, again :)

Signature · 1 line
SUSE Labs, Novell Inc.
#2 lore raw
In reply to Rusty Russell
Quoted 5 lines · Rusty Russell
Quoted 1 line · Matt

This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir. You can use "lib-y += pagewalk.o" there, and it seems to work as well as doing it in lib.

Are you sure? I tested that a few months ago and it didn't work for me. I seem to recall it wanted a chunk of makefile surgery.

Signature · 1 line
Mathematics is the supreme nostalgia of our time.
#3 lore raw
Quoted 9 lines · Matt Mackall
Quoted 5 lines · Rusty Russell
Quoted 1 line · Matt

This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir. You can use "lib-y += pagewalk.o" there, and it seems to work as well as doing it in lib.

Are you sure? I tested that a few months ago and it didn't work for me. I seem to recall it wanted a chunk of makefile surgery.

Well, I tested here and it worked unless I screwed something (producing lib.a in mm/ and linking it in). And when I turned off all the CONFIG options which required it, the symbols disappeared from the vmlinux...

Rusty.

#4 lore raw
Quoted 8 lines · Rusty Russell
Quoted 7 lines · Matt Mackall
Quoted 5 lines · Rusty Russell
Quoted 1 line · Matt

This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir. You can use "lib-y += pagewalk.o" there, and it seems to work as well as doing it in lib.

Quoted 6 lines
Quoted 2 lines

Are you sure? I tested that a few months ago and it didn't work for me. I seem to recall it wanted a chunk of makefile surgery.

Well, I tested here and it worked unless I screwed something (producing lib.a in mm/ and linking it in). And when I turned off all the CONFIG options which required it, the symbols disappeared from the vmlinux...

I think you had some additional change somewhere... kbuild will only look for lib.a files (produced from all files listed with lib-y _except_ files listed with obj-y too).

kbuild by default know about lib/ but almost all archs add the directory: arch/$(ARCH)/lib but no-one add mm/.
See assignment to libs-y.

Add see the bad documentation in Documentation/kbuild/makefiles.txt

Sam

#5 lore raw
Quoted 12 lines · Sam Ravnborg
Quoted 11 lines · Rusty Russell
Quoted 9 lines · Matt Mackall
Quoted 5 lines · Rusty Russell
Quoted 1 line · Matt

This lets it get shared outside of proc/ and linked in only when needed.

Erk, this really belongs in the mm dir. You can use "lib-y += pagewalk.o" there, and it seems to work as well as doing it in lib.

Are you sure? I tested that a few months ago and it didn't work for me. I seem to recall it wanted a chunk of makefile surgery.

Quoted 7 lines
Quoted 3 lines

Well, I tested here and it worked unless I screwed something (producing lib.a in mm/ and linking it in). And when I turned off all the CONFIG options which required it, the symbols disappeared from the vmlinux...

I think you had some additional change somewhere... kbuild will only look for lib.a files (produced from all files listed with lib-y _except_ files listed with obj-y too).

You're right: mm/lib.a gets built, but not linked in. Sorry for the false report...

Rusty.